Use a simpler behavior on volume bar , closes #351 #352
Conversation
Update style for volume bar
|
Can you post a screenshots please ? ^^ |
|
And check eslint too ;) |
src/styles/_header.scss
Outdated
| position: relative; | ||
| display: inline-flex; | ||
| padding-left: 1em |
src/styles/_header.scss
Outdated
| background-color: transparent; | ||
| } | ||
|
|
||
| + span { | ||
| margin: 2px 6px 0 |
|
My bad, i'll do better next time ! CI should pass now
|
|
Sorry for the delay, I will try to test it today, I might ask for a few changes |
|
@vprigent you might need to rebase, some commits landed on master |
|
@KeitIG anything else we need to do here? |
|
Two things:
|
|
My guess is that they may be skipped because of merge conflicts, so they don't even try |
|
I think it's because it is a PR from a Fork |
|
I think I fixed it for CircleCI, but not for AppVeyor |
|
Ok, I tested it (finally), why did you drop the show/hide feature?
Here's the problem. Initially I based the volume design on deezer.com player, the problem being: how to place a volume controller when you don't have enough place for it. I am closing it, let's discuss about problems and possible solutions in #351 |
|
You meant #351 probably |
Closes #351
Drop volume bar show/hide behavior
Update style for volume bar
I took some considerations on the new position :
I didn't wanted it to be too close of the player infos, as it is still a control element.
And still, wanted to separate it a little from the play/next/previous controls.