Some Album Art covers do not appear

[barreramarquez]

I have a pretty handful number of MP3 files that do not appear in new version of Museeks (0.20+) but does appear in old version (=<0.13.1). For reference, I have uploaded screenshots and the MP3 file in question.

Current version

Old version

MP3 file in question
https://drive.google.com/file/d/1h-CreQu3zmwWqi8S7hhaR70iBcXfvLcv/view?usp=sharing

Thank you.

[martpie]

Thank you for sending a file, I will have a look at what is going wrong :)

[adamltaylor]

I see a similar issue with Museeks 0.20.6 on Ubuntu 24.04.1. Looking at the files that do/don't show cover art in Puddletag, it looks like the ones that do show cover art have the artwork tagged as "CF" (CD Front Cover), whereas the ones that don't show have the artwork tagged as "O" (Other). All the files I've looked at have ID3v2.3 tags. Arguably a problem with the tagging, but ya know, if Museeks checked for CF artwork and fell back to O artwork, I certainly wouldn't complain...

[martpie]

Thank you for the investigation, I will report that to the maintainer of the library I use to extract id3 tags. He's quite reactive :)

[uklotzde]

There is no standard for extracting cover art from files. Multiple images could be embedded in file tags. If applications want to show only a single image they need to make their own choice, depending on the use case.

[martpie]

Here's the logic fetching covers from a file:

https://github.com/martpie/museeks/blob/master/src-tauri/src/plugins/cover.rs#L28-L31

Indeed I'm only checking for the front cover, but adding another fallback should be doable.

I'm just afraid we could get "false positives", but at the same time, if it was the previous behavior when Museeks was build with Electon, then we might be ok.

[martpie]

Fixed in 0.20.7

[barreramarquez]

Thanks for the update. However, there were still two tracks not showing their album covers. Wonder what is wrong here?

Sample music file:

https://drive.google.com/file/d/1uSaygLpUURwGMMI6N_hFOsRCPLqYufns/view?usp=sharing
https://drive.google.com/file/d/1p215z7UIlIv5TP4VUHdCAAHQbaBuvZnM/view?usp=sharing

[martpie]

Thanks for sending the files! So each track can have multiple pictures embedded in their file.

Museeks need to perform some heuristics in order to pick the "best" one: for example, the front cover if it exists is a better image to display than the back cover.

What I could aim to do is the following:

• look for a "vetted" image first, like front cover, illustration, etc.
• if I cannot find any, just return the first picture found, regardless of its semantic

[barreramarquez]

I suggest you reuse the previous behavior of Museeks 0.13 when it deals with multiple covers. The previous version shows the covers properly.

[martpie]

Not as simple as just "reuse the previous behavior", 0.20 is a full rewrite of the back-end, including changes of libraries which provide now different results, hence the behavior change you're observing.

Said in another way: I have no idea what the previous behavior was exactly, and that requires investigating the source code of the previous id3 extractor lib.

I'll see what I can do.