Normalize backslashes in track paths to fix broken playlists on Windows #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, [email protected] adds tracks with slash paths ("C:/path/track.mp3"), but interprets playlist tracks with backslash paths ("C:\path\track.mp3"). Without resolving track paths (thus normalizing slashes to backslashes), playlists will never find tracks to add, and thus will always be empty.
You can see this by creating a test directory, and placing a
track.mp3
and aplaylist.m3u
in the directory. Inplaylist.m3u
, have one line adding the track:Upon adding the directory to the library on [email protected], the playlist will be empty (here,
resolved filePath
is without the resolution; I just forgot to take out theconsole.log
):However, by resolving the
filePath
for each track, the playlist will be interpreted correctly:The PR also updates a small number of outdated comments.