Added credentials = include for fetch #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, this came up the other day (#203) but wasn't certain if this was a common case or not. It seems like that is the case so happy to accept this change. I'm going to be releasing Marty v0.9 tomorrow so I'd prefer to introduce this change in that release. #209 implements this change as an http hook so you can opt out if you want. One small change I made was to make credentials |
|
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Chrome 42 is on the beta channel we will start to use the native fetch implementation. This varies in a lot of ways form a traditional XHR request. One of the most obvious is that it omits sending cookies by default. This PR changes that default to
includemode, which is similar to what we're used to.