Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Generic uncaught exception handling #125

Closed
RazzM13 opened this issue Mar 29, 2018 · 1 comment
Closed

Generic uncaught exception handling #125

RazzM13 opened this issue Mar 29, 2018 · 1 comment

Comments

@RazzM13
Copy link
Contributor

RazzM13 commented Mar 29, 2018

Apparently, cfn-lint circumvents NodeJS's default behaviour of returning an exit code of 1 when an uncaught exception bubbles up to the event loop.

Steps to reproduce:

  1. Trigger an uncaught exception (e.g. attempt to validate a non-existing file).
  2. Check the exit code.
    validate.log
@RazzM13
Copy link
Contributor Author

RazzM13 commented Mar 29, 2018

This is probably the root cause of #121. After a bit of investigation I believe that the culprit is the winston logger and the most likely fix is to set exitOnError to true in the logger.ts file.

@martysweet martysweet added this to the v1.6.0 milestone Apr 2, 2018
RazzM13 added a commit to RazzM13/cfn-lint that referenced this issue Apr 4, 2018
martysweet added a commit to RazzM13/cfn-lint that referenced this issue Apr 4, 2018
martysweet added a commit to RazzM13/cfn-lint that referenced this issue Apr 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants