This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Implemented NodeJS compatibility test. #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe #127 should be merged first. |
|
Can the checking scripts be moved to a new folder? Perhaps |
|
Addressed the above mentioned issue, the last one from #111 and I also took the liberty of guarding against a false-negative scenario. Ready for review :) |
martysweet
suggested changes
Apr 4, 2018
|
|
||
| # Run the tests on all available versions | ||
| for version in ${node_versions}; do | ||
| echo "Testing node-${version}!"; |
There was a problem hiding this comment.
Can this for block be indented?
| source ~/.envirius/nv | ||
|
|
||
| if [ $? -ne 0 ]; then | ||
| echo "Unable to install envirius!" |
|
|
||
| # Dump available versions to file | ||
| for version in ${node_versions}; do | ||
| echo ${version} >> nodes_available.log |
|
|
||
| # Cache NodeJS environments | ||
| for version in ${node_versions}; do | ||
| echo "Adding NodeJS ${version} into environment cache!" && \ |
| echo "***Started test-run for ${version}***"; | ||
| cat "test_node_${version}.log"; | ||
| echo "***Finished test-run for ${version}***"; | ||
| done |
| @@ -28,6 +28,21 @@ jobs: | |||
| - run: | |||
| name: test | |||
| command: npm test | |||
| - run: | |||
|
I think everything should be fine now ;) |
martysweet
reviewed
Apr 4, 2018
| # Quick check | ||
| if [ "$1" == "--quick" ]; then | ||
| lts_versions=$( | ||
| for lts in 4 6 8 9; do |
There was a problem hiding this comment.
lts_version=$(
for lts in 4....
done
)
|
I'm really bad with indentation :)) Hopefully it's ok now. |
martysweet
approved these changes
Apr 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances #111.