Issue #140 - Fixed parsing of parameter values that contain commas that have been properly escaped using a backslash. #141
Conversation
…properly escaped using a backslash.
|
This is not ready yet, tests are coming but that's going to have to wait until tomorrow. |
RazzM13
force-pushed
the
list_type_parameters
branch
from
ed428fc to
cfb6929
Compare
|
This should be ready for merging. |
RazzM13
changed the title
src/index.ts
Outdated
| @@ -11,7 +11,17 @@ let firstArg: string | undefined = undefined | |||
| let secondArg: string = undefined!; | |||
|
|
|||
| function list(val: string) { | |||
There was a problem hiding this comment.
Comments explaining the use of this please, where is this used?
| @@ -118,6 +118,24 @@ describe('index', () => { | |||
| done(); | |||
| }); | |||
| }).timeout(5000); | |||
|
|
|||
| it('parameters of the CommaDelimitedList type should accept lists as values', (done) => { | |||
| exec('node lib/index.js validate testData/valid/yaml/parameters_type_commadelimitedlist.yaml --parameters SomeParam="test\\,dev\\,prod"', function(error, stdout, stderr) { | |||
There was a problem hiding this comment.
Can this be mentioned in the docs?
something,something,something is possible
|
Hi @martysweet, I'm guessing this should be complete... anything else? 😃 |
|
Looks great! |
|
@RazzM13 were the additions to aws_parameter_types.json necessary? I'm not sure they were needed (at least they shouldn't have been, it's quite possible my code was dodgy and doesn't work though :) ) |
|
@akdor1154 Can you create an issue and reference this PR? Otherwise, it will get lost. 😀 |
|
Hi @akdor1154, I believe that I refactored that particular part and it does appear connected now: |
#140 - Fixed parsing of parameter values that contain commas that have been properly escaped using a backslash.