Skip to content
This repository has been archived by the owner on Apr 16, 2022. It is now read-only.

Issue #164 #165

Merged
merged 4 commits into from
May 8, 2018
Merged

Issue #164 #165

merged 4 commits into from
May 8, 2018

Conversation

RazzM13
Copy link
Contributor

@RazzM13 RazzM13 commented May 8, 2018

Fixes #164.

@akdor1154
Copy link
Contributor

Looks good, and sorry for causing this breakage. I would probably write Array.isArray(data) ? data : data.split('.'), but this is getting into realms of personal opinion and it's not my project. :)

@RazzM13
Copy link
Contributor Author

RazzM13 commented May 8, 2018

Hi @akdor1154, you have nothing to be sorry for, thank you very much for the code style hint, I'm very new to Typescript and I'm not really fond of the cheeky Javascript-style !! value coercion and last but not least, thank you very much for trying to improve the codebase, I'm quite curious to see the new bounded functions from PR #156 though I haven't really had the time to look at the code yet.

@martysweet martysweet added this to the v1.7.1 milestone May 8, 2018
@martysweet martysweet merged commit 8036ea7 into martysweet:master May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants