This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Add support for AWS::Partition pseudo parameter #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the AWS::URLSuffix to the reference value overrides reference data, as well as to the type used for this value in code. This is a perfectly valid pseudo parameter (as per https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/pseudo-parameter-reference.html#cfn-pseudo-param-urlsuffix) but was causing an error at https://github.com/nskoufis/cfn-lint/blob/master/src/validator.ts#L680
Adding build artifacts so we can use them directly.
Accidentally included
This adds a very simple test that ensures that my minimum working broken example now passes.
This is a valid pseudo parameter as documented here: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/pseudo-parameter-reference.html#cfn-pseudo-param-partition This adds support for it, because at the moment it causes critical validation failures. Tests to follow.
This adds a simple test that ensures that the AWS::Partition pseudo parameter is correctly handled and parsed as valid.
|
@nskoufis Thanks for your work on this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #178, tests included.
Please let me know if there's anything more you want me to add.