This repository has been archived by the owner on Apr 16, 2022. It is now read-only.
Updating package dependencies to fix DoS vulnerability #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martysweet
reviewed
Apr 2, 2019
There was a problem hiding this comment.
Hi @acolombier,
Thanks for your contribution to patch this vulnerability with a dependency! The build failed as js-yaml was moved out of the dependencies to devDependencies, however, it is used at runtime.
Marty
package.json
Outdated
| "dependency-check": "^2.9.1", | ||
| "proxyquire-2": "^1.0.7" | ||
| "js-yaml": "^3.13.0", |
There was a problem hiding this comment.
This should be a dependency, not dev dependency.
acolombier
force-pushed
the
feature/security-fix
branch
from
7aaff61 to
0e57a85
Compare
|
Hi @martysweet Sorry about the mistake. I fixed it and also had to lock Antoine |
|
Thanks @acolombier, this will be released shortly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependency
js-yamlto fix medium security issue. Snyk report here