Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Roles to GH-Actions #132

Closed
chrisjsewell opened this issue Oct 13, 2020 · 3 comments
Closed

Update Roles to GH-Actions #132

chrisjsewell opened this issue Oct 13, 2020 · 3 comments
Labels
roles Requires changes to one or more roles testing

Comments

@chrisjsewell
Copy link
Member

All roles should be standardised to use GH-actions, plus the same code style and test infrastructure.

Also testing, where possible, should be updated to run against ubuntu 20.04, rather than 16.04, since 16.04 ships with python 3.5, which aiida-core no longer supports.

I have done this in marvel-nccr/ansible-role-aiida#45, and pulled out the common files (replacing the role name with a jinja variable {{ name }}) into:

https://gist.github.com/chrisjsewell/c8b4465e1bc006f483d9313d3a33eff4

Originally posted by @ltalirz in marvel-nccr/ansible-role-aiida#45 (comment)

P.S. It might be useful to open an issue on quantum mobile to keep track the progress of moving roles to github actions.

Since there are >30 roles it might be worth thinking about a (semi-)automated way of migrating a role (run some script, ...); I still remember when I needed to move roles to molecule 3 and I thought automation wasn't necessary but in the end I might have saved a bit of time since one easily makes mistakes when doing everything by hand.

@chrisjsewell
Copy link
Member Author

@chrisjsewell chrisjsewell added roles Requires changes to one or more roles testing labels Oct 15, 2020
chrisjsewell added a commit to marvel-nccr/ansible-role-slurm that referenced this issue Oct 20, 2020
chrisjsewell added a commit to marvel-nccr/ansible-role-bigdft that referenced this issue Oct 20, 2020
chrisjsewell added a commit to marvel-nccr/ansible-role-wannier90 that referenced this issue Oct 20, 2020
chrisjsewell added a commit to marvel-nccr/ansible-role-bigdft that referenced this issue Oct 20, 2020
chrisjsewell added a commit to marvel-nccr/ansible-role-siesta that referenced this issue Oct 20, 2020
chrisjsewell added a commit to marvel-nccr/ansible-role-wannier90 that referenced this issue Oct 21, 2020
See marvel-nccr/quantum-mobile#132

Also fix bug with the `make clean` command
chrisjsewell added a commit to marvel-nccr/ansible-role-siesta that referenced this issue Oct 21, 2020
chrisjsewell added a commit to marvel-nccr/ansible-role-aiidalab that referenced this issue Oct 21, 2020
@chrisjsewell
Copy link
Member Author

I think that's just about all the roles that are actively used in the quantum mobile build now updated

@ltalirz
Copy link
Member

ltalirz commented Mar 25, 2021

Thanks a lot for this @chrisjsewell !

Any further roles can be updated later

@ltalirz ltalirz closed this as completed Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roles Requires changes to one or more roles testing
Projects
None yet
Development

No branches or pull requests

2 participants