-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Es1 4 final steps #198
Open
MisakaZentai
wants to merge
31
commits into
marvelai-org:develop
Choose a base branch
from
mickey4653:ES1-4-FinalSteps
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Es1 4 final steps #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created env file for config - updated firebase rules - and updated the firebase project name
- fixed Eslint errors - Created a component template and Design Quick Action Button - implemented efficiency state management. (ES2.4) - implemented user feedback using loading state. (ES2.4)
- added more quick action buttons
- fixed Eslint Errors - Added Other Quick Action buttons
- Removed Close icon - added padding between quick action button text and icon
- added styling for other quick action buttons - added disabled state - made text for quick action buttons dynamic - added default buttion for quick action
- fixing pop up quick action buttons responsiveness - made buttons dynamic passed through text
- Created Discover Library branch
- Created a Page for discovery Library - added discoveryLibrary UI template in chat template directory - Design and integrated Discovery Library UI
- added images to custom prompts
- Fixed ESlint errors - added discover librari UI template - made chat template reusable into hooks
- removed background on cards
- got changes from surbhi (discovery button) - routed discovery button to discovery library ui page
- added user dynamic state when user logs in
- made sure discovery button is centered correctly
- added route to discovery library ui
- Created OnBoarding Component for welcome page - created page to route to welcome page - addded some styling for welcome page design
- imported image dropdown icon - created routes to profile setup - created and designed progress bar component - made progress bar resusable props in welcome screen component
- recreated progress bar component due to bug issue - Refactored the code for progress bar component - removed unnecessary stylings on welcome component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MisakaZentai,
What issue is this Pull Request actually resolves. Can you update the pull request with all the details filled within PR template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I implement the final step pages.
Related Issue
If this PR addresses an issue, link to it here.
Type of Change
Please select the type(s) of change that apply and delete those that do not.
Proposed Solution
Describe your code changes in detail. Explain how you implemented your solution and any design decisions you made.
How to Test
Provide instructions on how to test these changes. Include details on test configurations, test cases, and expected outcomes.
Unit Tests
List the unit tests added or modified to verify your changes.
Documentation Updates
Indicate whether documentation needs to be updated due to this PR.
If yes, describe what documentation updates are needed and link to the relevant documentation.
Checklist
Additional Information
Add any other information that might be useful for the reviewers.