Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General code refactoring #32

Merged
merged 13 commits into from
Jul 13, 2023
Merged

General code refactoring #32

merged 13 commits into from
Jul 13, 2023

Conversation

NicolaSmaniotto
Copy link
Collaborator

@NicolaSmaniotto NicolaSmaniotto commented Nov 5, 2022 •
edited
Loading

All these changes should not affect the functionality of the plugin.

Changes so far:

  • Changed how the closest thumbnail is found (useless optimization, but I don't see why not)
  • Simplified nil comparisons throughout
  • Removed some parentheses in function calls (though it may confuse someone not used to lua?)
  • Moved is_remote inside the thumbnailer
  • Make thumbnail generation depend on total thumbnails
  • Use mp.command_native

@NicolaSmaniotto
ensure the last thumbnail is generated
b83b150 
This fixes the list when thumbnail_count is a power of 2
@NicolaSmaniotto NicolaSmaniotto marked this pull request as ready for review November 7, 2022 09:27
@NicolaSmaniotto NicolaSmaniotto merged commit 21ccb89 into marzzzello:master Jul 13, 2023
@NicolaSmaniotto NicolaSmaniotto deleted the refactor branch July 13, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NicolaSmaniotto