remove relaxing option #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pixyz/distributions/distributions.py
…elaxing_option # Conflicts: # pixyz/distributions/distributions.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
動機
具象クラス
RelaxedBernoulliのためのオプションrelaxingは抽象クラスで指定されていました．このためDistributionBaseクラスの変更次第で，
RelaxedBernoulli以外の具象クラスでも不明なオプションを管理する必要が生じる場面があり問題だったため，relaxingオプションを削除し，RelaxedBernoulliを単一のモードで動作させることにしました．変更点
RelaxedBernoulliとRelaxedCategoricalのメソッド引数からrelaxingオプションを削除DistributionBaseからrelaxingオプションのデフォルト値指定を削除