Clone all params of distribution to fix a bug #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug regarding the saving/loading Pixyz object.
1. Probrem
First, I make
Normal
distributions with the same tensors. (p.loc=q.loc=q.scale
)Next, I make new distribution with different params & load them to old one.
Then, loaded params are not correct. Inplace-updates overwrites linked params.
2. Change
This is because
DistributionBase
class treats buffered parameters as variables of Reference types.Therefore, I added the clone() method when registering features. Although it wastes memory, it correctly works.
And this change is related to pull request #110. Just cloning solve its issue, so I removed some lines.