Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a range of time step & enable to use time step for time-specific … #133

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

ktaaaki
Copy link
Collaborator

@ktaaaki ktaaaki commented Oct 6, 2020

目的

IterativeLossのtimestep_varに関する2つのバグの修正

  • timestep_varに入ってくる実際の値と,latex式の添字の値の範囲が一致していない
  • slice_step関数を拡張しないとtimestep_varの値が内部変数として取得できない

内容

  • latex式の範囲をpythonの標準(0~N-1)に合わせた
  • デフォルトのtimestep_varを削除して,slice_stepに関係なく内部変数が欲しい場合を設定できるようにした
  • テストケースを追加

@masa-su masa-su merged commit 3be58d8 into develop/v0.2.1 Oct 6, 2020
@masa-su masa-su deleted the fix/timestep_var branch October 6, 2020 11:07
This was referenced Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants