Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/feature dims #163

Merged
merged 6 commits into from
Mar 2, 2021
Merged

Fix/feature dims #163

merged 6 commits into from
Mar 2, 2021

Conversation

ktaaaki
Copy link
Collaborator

@ktaaaki ktaaaki commented Dec 22, 2020 •
edited
Loading

Issue

The feature_dims option is disabled in get_log_prob, get_entropy, etc.. So you need to manually operate a resulting tensor when you want to keep dimensions other than batch dimension.

Solution

  • Enabled the feature_dims option.
  • The dimensional restriction imposed on sum_samples has been lifted.

@ktaaaki ktaaaki changed the base branch from fix/graph_option to develop/v0.3.2 January 12, 2021 03:52
@ktaaaki ktaaaki changed the title [WIP] Fix/feature dims Fix/feature dims Jan 12, 2021
@masa-su masa-su merged commit 7ad8ff5 into develop/v0.3.2 Mar 2, 2021
@masa-su masa-su deleted the fix/feature_dims branch March 2, 2021 07:20
@ktaaaki ktaaaki mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktaaaki @masa-su