feat: return empty array if ignoreDuplicateMessages is enabled (Chain…

…Safe#402)

src/index.ts

@@ -110,7 +110,7 @@ export interface GossipsubOpts extends GossipsubOptsSpec, PubSubInit {
   /** Do not throw `InsufficientPeers` error if publishing to zero peers */
   allowPublishToZeroPeers: boolean
   /** Do not throw `PublishError.Duplicate` if publishing duplicate messages */
-  allowPublishDuplicates: boolean
+  ignoreDuplicateMessages: boolean
   /** For a single stream, await processing each RPC before processing the next */
   awaitRpcHandler: boolean
   /** For a single RPC, await processing each message before processing the next */
@@ -2016,11 +2016,14 @@ export class GossipSub extends EventEmitter<GossipsubEvents> implements PubSub<G
     const msgIdStr = this.msgIdToStrFn(msgId)
 
     // Current publish opt takes precedence global opts, while preserving false value
-    const allowPublishDuplicates = opts?.allowPublishDuplicates ?? this.opts.allowPublishDuplicates
+    const ignoreDuplicateMessages = opts?.ignoreDuplicateMessages ?? this.opts.ignoreDuplicateMessages
 
-    if (this.seenCache.has(msgIdStr) && !allowPublishDuplicates) {
+    if (this.seenCache.has(msgIdStr)) {
       // This message has already been seen. We don't re-publish messages that have already
       // been published on the network.
+      if (ignoreDuplicateMessages) {
+        return { recipients: [] }
+      }
       throw Error('PublishError.Duplicate')
     }
 

src/types.ts

@@ -74,7 +74,7 @@ export enum SignaturePolicy {
 
 export type PublishOpts = {
   allowPublishToZeroPeers?: boolean
-  allowPublishDuplicates?: boolean
+  ignoreDuplicateMessages?: boolean
 }
 
 export enum PublishConfigType {