Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize pytest #1

Merged
merged 490 commits into from
Nov 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
490 commits
Select commit Hold shift + click to select a range
0367be5
Use doublequotes (Black)
fa2k Oct 23, 2023
3475626
Merge pull request #2482 from bjlang/dev
bjlang Oct 23, 2023
3f3fc9f
Move to new release
fa2k Oct 23, 2023
1a9d973
Merge pull request #2458 from mashehu/add-retry-functionality
mashehu Oct 24, 2023
3c6af2d
Extracted container link check, fix tests
fa2k Oct 24, 2023
5283677
generalize nextflow_cmd to run_cmd to use the same structure for nf-test
mashehu Oct 24, 2023
0081766
initial changes for nf-test
mashehu Oct 24, 2023
d9126e5
move tags.yml to correct position
mashehu Oct 24, 2023
ecda687
Update nf_core/utils.py
mashehu Oct 24, 2023
955321b
convert all cmds
mashehu Oct 24, 2023
0a4afac
first running version
mashehu Oct 24, 2023
ca233d1
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Oct 24, 2023
86613b6
replace params
mashehu Oct 24, 2023
e0c30cd
fix typing errors
mashehu Oct 24, 2023
a2d69af
Merge pull request #2489 from fa2k/check-spaces-in-container-links
fa2k Oct 25, 2023
5682b7b
fix linting for nf-test only modules
nvnieuwk Oct 25, 2023
ef18cbd
small fix for when pytest exists
nvnieuwk Oct 25, 2023
8fd8d76
improved the error messages a bit
nvnieuwk Oct 25, 2023
3a7315f
add the same logic to subwf lint
nvnieuwk Oct 25, 2023
c93e2e0
black
nvnieuwk Oct 25, 2023
f0afb7b
update changelog
nvnieuwk Oct 25, 2023
a9f55ba
add TODO comments to main.nf.test and fix tags.yml template rendering
mirpedrol Oct 25, 2023
865d613
add todo comment for chained modules
mirpedrol Oct 25, 2023
df78dfc
show warnings instead of failures for nf-test
nvnieuwk Oct 26, 2023
73831ae
fix typo
nvnieuwk Oct 26, 2023
d767c78
add real example to main.nf.test
mirpedrol Oct 26, 2023
876eab3
add tags.yml to prettierignore
mirpedrol Oct 26, 2023
3b9f031
add main.nf.test to template instead of using nf-test
mirpedrol Oct 26, 2023
8341794
Update nextflow.config
maxulysse Oct 27, 2023
b38c0f6
Merge pull request #2494 from nvnieuwk/nf-test-module-lint
nvnieuwk Oct 31, 2023
79215fb
generalize nextflow_cmd to run_cmd to use the same structure for nf-test
mashehu Oct 24, 2023
7cab286
initial changes for nf-test
mashehu Oct 24, 2023
f41d410
move tags.yml to correct position
mashehu Oct 24, 2023
cbc398a
convert all cmds
mashehu Oct 24, 2023
8d7794a
first running version
mashehu Oct 24, 2023
1a58690
replace params
mashehu Oct 24, 2023
86db72b
fix typing errors
mashehu Oct 24, 2023
7a7fd93
add TODO comments to main.nf.test and fix tags.yml template rendering
mirpedrol Oct 25, 2023
11773ef
add todo comment for chained modules
mirpedrol Oct 25, 2023
eafb3b5
add real example to main.nf.test
mirpedrol Oct 26, 2023
56086c6
add tags.yml to prettierignore
mirpedrol Oct 26, 2023
63c3188
add main.nf.test to template instead of using nf-test
mirpedrol Oct 26, 2023
4038131
modules create tests check for main.nf.test
mirpedrol Oct 31, 2023
43bf218
remove outputDir from the modules template
mirpedrol Oct 31, 2023
4ffc3cf
add nf-test to subworkflows
mirpedrol Oct 31, 2023
db10253
subworkflows create tests check for main.nf.test
mirpedrol Oct 31, 2023
a3eae4d
Merge branch 'migrate-component-create-to-nf_test' of https://github.…
mirpedrol Oct 31, 2023
80ddddb
fix tags for subtools, add version assertion to template
mashehu Nov 1, 2023
617010e
fix quotes in templates
mashehu Nov 1, 2023
04efb40
add first version of the `create-snapshot` command
mashehu Nov 1, 2023
71c441c
install all type specific dependencies in CI step
mashehu Nov 1, 2023
a7cfdd5
add new command 🙃
mashehu Nov 2, 2023
d6b9f6c
remove tests for modules create_test_yml
mashehu Nov 2, 2023
6b0ff49
remove more mentions of test_yml_builder
mashehu Nov 2, 2023
0045d4d
add types to create-snapshot and use component_type
mirpedrol Nov 2, 2023
61459f5
add subworkflows create-snapshot
mirpedrol Nov 2, 2023
6b63566
add linting for snapshot file
mashehu Nov 6, 2023
73487dd
add correct tags to subworkflow template
mashehu Nov 6, 2023
cdf5f63
fix smaller things according to mypy
mashehu Nov 6, 2023
a1743cd
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Nov 6, 2023
bff7e89
add pytests for components snapshot generator
mirpedrol Nov 7, 2023
2f5312a
add more typing
mashehu Nov 7, 2023
ef52c75
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Nov 7, 2023
f42fe20
run create-snapshot tests from modules root directory
mirpedrol Nov 7, 2023
6ef6268
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Nov 7, 2023
e79d4d3
fix checking if PROFILE exists
mirpedrol Nov 7, 2023
c7bc5b7
add new environment.yml setup to template according to #2495
mashehu Nov 8, 2023
3f46c16
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Nov 8, 2023
53b23b7
use set_wd for tests
mirpedrol Nov 8, 2023
fc1f219
add csv syntax highlighting in template
mashehu Nov 8, 2023
82a355d
update changelog
mashehu Nov 8, 2023
c4683f0
check md5sums and add snapshot test for a subworkflow
mirpedrol Nov 8, 2023
ecdb55b
Merge pull request #2503 from mashehu/add-csv-syntax-highlighting
mashehu Nov 8, 2023
2a640cc
append error messages to self.errors
mashehu Nov 8, 2023
fa0c6f3
add --dir option to create-snapshot command
mirpedrol Nov 8, 2023
f5ddc64
add no test found error and test for this
mirpedrol Nov 9, 2023
163019d
add test for unstable snapshot
mirpedrol Nov 9, 2023
8ebf36a
don't assert run() function from snapshot generator
mirpedrol Nov 9, 2023
749ba53
Update tests/components/create_snapshot.py
mirpedrol Nov 9, 2023
ecc40ff
use closure for multiqc ext.args + use pattern to exclude versions.yml
maxulysse Nov 9, 2023
7f4f856
update CHANGELOG
maxulysse Nov 9, 2023
92c21aa
cannot exclude in glob pattern
maxulysse Nov 9, 2023
faa2c06
update CHANGELOG
maxulysse Nov 9, 2023
4ed0587
Merge pull request #2509 from nf-core/maxulysse-patch-2
maxulysse Nov 9, 2023
e999191
handle custom error messages from schemas
mashehu Nov 10, 2023
6217be4
Merge pull request #2511 from mashehu/handle-custom-schema-error-mess…
mashehu Nov 10, 2023
3f0bc4c
Merge pull request #2496 from nf-core/maxulysse-patch-1
mirpedrol Nov 10, 2023
b1b57d3
add linting code for environemnt.yml
mashehu Nov 13, 2023
2c40da9
respect indentation on version bump
mashehu Nov 13, 2023
b536834
update changelog
mashehu Nov 13, 2023
26d0128
apply code suggestions
mashehu Nov 13, 2023
55faca8
add missing closing quote
mashehu Nov 13, 2023
495b08f
fix output
mashehu Nov 13, 2023
acf59c6
fix type error
mashehu Nov 13, 2023
5aad9c4
add hint for language server, update to new new for schema file
mashehu Nov 13, 2023
ed68cfe
Merge pull request #2514 from mashehu/respect-identation-on-version-bump
mashehu Nov 13, 2023
aaa5945
add types
mashehu Nov 13, 2023
9fe1c3e
add schema based validation to environment yaml linting, add tests
mashehu Nov 13, 2023
92fd677
Merge branch 'dev' into migrate-component-create-to-nf_test
mashehu Nov 13, 2023
2d51ff8
fix mypy
mashehu Nov 13, 2023
74139bd
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Nov 13, 2023
54bb5b6
fix type error
mashehu Nov 13, 2023
28c1c76
add nf-test dependency
mashehu Nov 13, 2023
dc7a330
install nf-test for ci
mashehu Nov 13, 2023
1ce81c0
switch bump_version to use environemt.yml
mashehu Nov 14, 2023
32ef61b
update modules in pipeline template
mashehu Nov 14, 2023
ab113c7
fix test for updated snapshot
mashehu Nov 14, 2023
bec4bb3
test for name mismatch in environment.yml
mashehu Nov 14, 2023
0622fbc
make nicer diff for nf-test error
mashehu Nov 14, 2023
4c30da3
fix error in download test
mashehu Nov 14, 2023
2ca1764
don't convert arrays to strings in licence field
mashehu Nov 14, 2023
6e2dc70
add nf-test to CI
mashehu Nov 14, 2023
cb175e7
fix environment.yml linting
mashehu Nov 14, 2023
38d9db7
rely on environment.yml for bioconda versions
mashehu Nov 14, 2023
91c24e6
fix tests
mashehu Nov 14, 2023
dc6d033
fix types
mashehu Nov 14, 2023
d82bf66
remove subworkflows test_yml_builder and fix subworkflow tests
mirpedrol Nov 15, 2023
24ff636
fix nf-test setup in CI
mashehu Nov 15, 2023
20ae7b1
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Nov 15, 2023
72a78c0
fix assertion value
mashehu Nov 15, 2023
d687430
handle local modules without nf-test
mashehu Nov 15, 2023
f673a89
add linting for nf-test and remove linting for pytests
mirpedrol Nov 15, 2023
bb070c6
fix linting components errors
mirpedrol Nov 15, 2023
b4057ca
Update slackreport.json
maxulysse Nov 16, 2023
fa5e84f
add licence to mock anaconda call
mashehu Nov 16, 2023
3b03e4c
fix licence type again
mashehu Nov 16, 2023
d9d8eb0
give better hint, fix tests
mashehu Nov 16, 2023
e19a4a2
remove tmp dir manually if we find a PermissionError
mirpedrol Nov 16, 2023
25697bc
Merge pull request #2517 from mashehu/fix-linting-with-new-schema
mashehu Nov 16, 2023
f92ca88
Merge branch 'dev' into maxulysse-patch-2
mashehu Nov 16, 2023
5e02619
fix launch tests, move tmp pipeline creation to utils to share betwee…
mashehu Nov 16, 2023
316055f
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Nov 16, 2023
7b0683e
fix tests by correcting raised error type
mashehu Nov 16, 2023
22a9071
fix tests, switch to pdiff instead of icdiff, because it handles widt…
mashehu Nov 16, 2023
a8f6332
revert e19a4a250bf7a8a4ebd484f94cc39b324642081f
mirpedrol Nov 16, 2023
5347b56
Apply suggestions from code review
mashehu Nov 16, 2023
fc0a3fc
remove debugging raise introduced by mistake
mirpedrol Nov 16, 2023
c576cc8
fix module name in the version of stub scripts
mirpedrol Nov 17, 2023
2ac549d
add maintainers to meta.yml
mirpedrol Nov 17, 2023
ddfa470
Merge pull request #2520 from mirpedrol/module-template
mirpedrol Nov 17, 2023
d12560d
move create-snapshot command to test command
mirpedrol Nov 20, 2023
300289e
move modules and subworkflows test tests to components
mirpedrol Nov 20, 2023
c254699
add test for generate snapshot once
mirpedrol Nov 20, 2023
bb640bb
update README
mashehu Nov 20, 2023
c550823
Apply suggestions from code review
mashehu Nov 20, 2023
2b15177
fix typing errors
mashehu Nov 20, 2023
8d5550e
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Nov 20, 2023
f4a48b5
remove last traces of create-snapshot or create-test-yml
mashehu Nov 20, 2023
9f2f905
fix parameters
mashehu Nov 20, 2023
f288520
update changelog
mashehu Nov 20, 2023
7722d52
rename create_snapshot functions and files
mashehu Nov 20, 2023
71c0b08
simplify obsolete check
mashehu Nov 21, 2023
d29643e
add back option to handle pytest based modules in bump_version
mashehu Nov 21, 2023
4d08f6d
rename generator to test to make it hopefully less confusing
mashehu Nov 21, 2023
0c120ab
automatically sort dependencies in environment.yml while linting
mashehu Nov 21, 2023
dc5c7cb
fix types
mashehu Nov 21, 2023
bcf22a1
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Nov 21, 2023
a5a3fd4
fix typo
mashehu Nov 21, 2023
41b61c1
fix import statement
mashehu Nov 21, 2023
d2df78a
Update nf_core/components/components_test.py
mashehu Nov 21, 2023
75a07c4
remove self.run_tests
mashehu Nov 21, 2023
b4ff558
Merge branch 'migrate-component-create-to-nf_test' of github.com:mash…
mashehu Nov 21, 2023
4093f87
Merge pull request #2490 from mashehu/migrate-component-create-to-nf_…
mashehu Nov 21, 2023
0bcc6d8
add mypy check
mashehu Nov 21, 2023
e1f913e
run full test matrix only on PRs to the master branch, update python …
mashehu Nov 21, 2023
3878199
only run mypy step for PRs against dev
mashehu Nov 21, 2023
1be57f6
upgrade to python 3.12
mashehu Nov 21, 2023
f6aab22
Merge pull request #2521 from mashehu/add-mypy-check
mashehu Nov 21, 2023
52d900e
Merge branch 'dev' into reduce-ci-matrix-on-dev
mashehu Nov 21, 2023
c31744a
Merge branch 'dev' into reduce-ci-matrix-on-dev
mashehu Nov 21, 2023
fa3f6b7
add manual dispatch exception to mypy check
mashehu Nov 21, 2023
5bba99c
add mypy.ini
mashehu Nov 21, 2023
c23fed6
add it to the action
mashehu Nov 21, 2023
a1ef6c0
Revert "Add mypy check"
mirpedrol Nov 21, 2023
41d8fe2
linting tests requiring nf-test will be warnings instead of failures
mirpedrol Nov 21, 2023
7fe54c6
keep linting failing for component with nf-test
mashehu Nov 21, 2023
3446c0b
fix typo
mashehu Nov 21, 2023
2720bf9
Merge pull request #2523 from nf-core/revert-2521-add-mypy-check
mashehu Nov 22, 2023
3a556d0
Merge branch 'dev' into linting-nftest-warn
mashehu Nov 22, 2023
b8c66fb
Merge pull request #2524 from mirpedrol/linting-nftest-warn
mirpedrol Nov 22, 2023
f5ba5f6
Merge branch 'dev' into maxulysse-patch-2
maxulysse Nov 23, 2023
417533d
Merge pull request #2516 from nf-core/maxulysse-patch-2
mashehu Nov 23, 2023
e6d6f2c
move set_wd from tests/utils.py to utils.py
mashehu Nov 23, 2023
b51eba2
Merge pull request #2529 from mashehu/mv-set_wd
mashehu Nov 23, 2023
e3113d9
lint for removal of old pytest files
mashehu Nov 23, 2023
fbc228e
tests, tests, tests
mashehu Nov 23, 2023
678d22e
nudge people to snapshot all of their output
mashehu Nov 23, 2023
b3798f7
Merge pull request #2532 from mashehu/more-global-snapshot
mashehu Nov 23, 2023
ce5ccea
Merge pull request #2531 from mashehu/lint-for-pytest-removal
mashehu Nov 24, 2023
4157d78
improve testing coverage for meta_yml
mashehu Nov 27, 2023
94e55b8
Merge branch 'dev' of github.com:nf-core/tools into test-modules-bump
mashehu Nov 27, 2023
5965e73
Merge branch 'dev' of github.com:nf-core/tools into reduce-ci-matrix-…
mashehu Nov 27, 2023
8b4addf
Merge pull request #2522 from mashehu/reduce-ci-matrix-on-dev
mashehu Nov 27, 2023
955443b
Apply suggestions from code review
mashehu Nov 27, 2023
b7ce74f
Merge branch 'dev' of github.com:nf-core/tools into test-modules-bump
mashehu Nov 27, 2023
8ef0621
log to info instead of debug.
mashehu Nov 27, 2023
9d4bd0e
fix mypy errors
mashehu Nov 27, 2023
341dbdf
fix type comments
mashehu Nov 27, 2023
295a44a
fix: use double quotes for interpretable string
Midnighter Nov 27, 2023
7a4ddfc
fix: correct implicit variable name
Midnighter Nov 27, 2023
1faff58
docs: describe fix in changelog
Midnighter Nov 27, 2023
db3c449
Merge pull request #2539 from mashehu/test-modules-bump
mashehu Nov 27, 2023
1f3b28f
Merge branch 'dev' of github.com:nf-core/tools into fix-conda
mashehu Nov 27, 2023
8f9b851
split jobs up to only run once on dev
mashehu Nov 27, 2023
442b17a
check condition before setting up anything
mashehu Nov 27, 2023
26cc37b
fix copy-paste error
mashehu Nov 27, 2023
f54b9f2
fix variable name in lint test
mashehu Nov 27, 2023
36ec793
fix incorrectly guessed syntax
mashehu Nov 27, 2023
84f92bc
fix: adjust quotes to match template
Midnighter Nov 27, 2023
3a3ecbc
Merge pull request #2540 from nf-core/fix-conda
Midnighter Nov 27, 2023
d2c5400
add mypy to pre-commit config, fix mypy errors
mashehu Nov 28, 2023
62ee35e
try different condition and without accessing the matrix
mashehu Nov 28, 2023
b442d50
use same naming for modules and subworkflo commands
mashehu Nov 28, 2023
c78017b
Merge pull request #2541 from mashehu/reduce-ci-matrix-on-dev
mashehu Nov 28, 2023
ed8efbc
update github checkout and setup-python
mashehu Nov 28, 2023
6d7ab36
Merge branch 'dev' of github.com:nf-core/tools into add-mypy-to-pre-c…
mashehu Nov 28, 2023
ae505c4
switch to self-hosted 🤞🏻
mashehu Nov 28, 2023
1ad27a7
Revert "switch to self-hosted 🤞🏻"
mashehu Nov 28, 2023
13bbac6
fix subworkflow command
mashehu Nov 28, 2023
ead61f4
Merge pull request #2545 from mashehu/add-mypy-to-pre-commit
mashehu Nov 28, 2023
3b7a9c2
Merge branch 'dev' into fix-swf-linting-error
mashehu Nov 28, 2023
ad03acd
fix parsing for include statement of nested subworkflows, print long …
mashehu Nov 28, 2023
4356351
Merge branch 'fix-swf-linting-error' of github.com:mashehu/tools into…
mashehu Nov 28, 2023
7f869b1
Merge pull request #2546 from mashehu/fix-swf-linting-error
mashehu Nov 29, 2023
da7636a
fix subworkflow tag in template
mashehu Nov 29, 2023
cc3b6e1
fix linting tests
mashehu Nov 29, 2023
c6ff441
try once more on self hosted
mashehu Nov 29, 2023
ffba25f
run even more things on aws
mashehu Nov 29, 2023
d64c3b9
fix node setup
mashehu Nov 29, 2023
7f6bc73
fix apt command
mashehu Nov 29, 2023
a84d064
reset aws runner for nf-test related things, try it with other workflows
mashehu Nov 29, 2023
9599287
try fixing aws runs
mashehu Nov 29, 2023
88e8bce
run on github runners
mashehu Nov 29, 2023
20dbeec
Merge pull request #2548 from mashehu/fix-swf-linting-error
mashehu Nov 30, 2023
53bf326
try out new parallization strategy
mashehu Nov 30, 2023
bad63e9
fix cache in setup step
mashehu Nov 30, 2023
52385e6
Revert "fix cache in setup step"
mashehu Nov 30, 2023
0d84546
simplify workflow steps
mashehu Nov 30, 2023
ac20aec
remove trailing comma in test list
mashehu Nov 30, 2023
8929bf4
fix test matrix format
mashehu Nov 30, 2023
ec057fd
run only folders and first level test files
mashehu Nov 30, 2023
0e23f58
remove trailing comma and data directory
mashehu Nov 30, 2023
80bef28
output json file
mashehu Nov 30, 2023
e4bf011
output as json object to matrix
mashehu Nov 30, 2023
f216a8f
just use test_ files
mashehu Nov 30, 2023
90967d7
don't fail if no tests were collected
mashehu Nov 30, 2023
5650736
update codecov action
mashehu Nov 30, 2023
c31b582
do codecov step at the end
mashehu Nov 30, 2023
7e3583e
use github runners
mashehu Nov 30, 2023
2672237
get around nextflow api
mashehu Nov 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"image": "nfcore/gitpod:latest",
"postCreateCommand": "python -m pip install --upgrade -r ../requirements-dev.txt -e ../ && pre-commit install --install-hooks",
"remoteUser": "gitpod",
"runArgs": ["--privileged"],

// Configure tool-specific properties.
"customizations": {
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/create-lint-wf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ jobs:
- "latest-everything"
steps:
# Get the repo code
- uses: actions/checkout@v3
- uses: actions/checkout@v4
name: Check out source-code repository

# Set up nf-core/tools
- name: Set up Python 3.8
- name: Set up Python 3.12
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.12

- name: Install python dependencies
run: |
Expand All @@ -48,7 +48,9 @@ jobs:
version: ${{ matrix.NXF_VER }}

# Install the Prettier linting tools
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "20"

- name: Install Prettier
run: npm install -g prettier
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/create-test-lint-wf-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ concurrency:

env:
NXF_ANSI_LOG: false
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
RunTestWorkflow:
Expand All @@ -32,13 +33,13 @@ jobs:
- "template_skip_nf_core_configs.yml"

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
name: Check out source-code repository

- name: Set up Python 3.8
- name: Set up Python 3.12
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.12

- name: Install python dependencies
run: |
Expand All @@ -51,7 +52,9 @@ jobs:
version: latest-everything

# Install the Prettier linting tools
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "20"

- name: Install Prettier
run: npm install -g prettier
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/create-test-wf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ jobs:
- "23.04.0"
- "latest-everything"
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
name: Check out source-code repository

- name: Set up Python 3.8
- name: Set up Python 3.12
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.12

- name: Install python dependencies
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
name: Check out source-code repository

- name: Set up Python 3.8
- name: Set up Python 3.12
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.12

- name: Install python dependencies
run: |
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/fix-linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
# Use the @nf-core-bot token to check out so we can push later
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
token: ${{ secrets.nf_core_bot_auth_token }}

Expand All @@ -24,7 +24,9 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.nf_core_bot_auth_token }}

- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "20"

- name: Install Prettier
run: npm install -g prettier @prettier/plugin-php
Expand All @@ -38,10 +40,10 @@ jobs:
# Override to remove the default --check flag so that we make changes
options: "--color"

- name: Set up Python 3.8
- name: Set up Python 3.12
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.12
- name: python-isort
uses: isort/[email protected]
with:
Expand Down
68 changes: 56 additions & 12 deletions .github/workflows/lint-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@ concurrency:

jobs:
EditorConfig:
runs-on: ubuntu-latest
runs-on: ["ubuntu-latest"]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "20"

- name: Install editorconfig-checker
run: npm install -g editorconfig-checker
Expand All @@ -28,11 +30,13 @@ jobs:
run: editorconfig-checker -exclude README.md $(git ls-files | grep -v 'test\|.py\|md\|json\|yml\|yaml\|html\|css\|Makefile')

Prettier:
runs-on: ubuntu-latest
runs-on: ["ubuntu-latest"]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "20"

- name: Install Prettier
run: npm install -g prettier
Expand All @@ -41,9 +45,9 @@ jobs:
run: prettier --check ${GITHUB_WORKSPACE}

PythonBlack:
runs-on: ubuntu-latest
runs-on: ["ubuntu-latest"]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Check code lints with Black
uses: psf/black@stable
Expand Down Expand Up @@ -71,17 +75,57 @@ jobs:
allow-repeats: false

isort:
runs-on: ubuntu-latest
runs-on: ["ubuntu-latest"]
steps:
- name: Check out source-code repository
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Python 3.8
- name: Set up Python 3.12
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.12
- name: python-isort
uses: isort/[email protected]
with:
isortVersion: "latest"
requirementsFiles: "requirements.txt requirements-dev.txt"

static-type-check:
runs-on: ["ubuntu-latest"]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: 3.12
cache: "pip"

- name: Install dependencies
run: |
python -m pip install --upgrade pip -r requirements-dev.txt
pip install -e .

- name: Cache nf-test installation
id: cache-software
uses: actions/cache@v3
with:
path: |
/usr/local/bin/nf-test
/home/runner/.nf-test/nf-test.jar
key: ${{ runner.os }}-${{ env.NFTEST_VER }}-nftest

- name: Install nf-test
if: steps.cache-software.outputs.cache-hit != 'true'
run: |
wget -qO- https://code.askimed.com/install/nf-test | bash
sudo mv nf-test /usr/local/bin/

- name: Get Python changed files
id: changed-py-files
uses: tj-actions/changed-files@v23
with:
files: |
*.py
**/*.py
- name: Run if any of the listed files above is changed
if: steps.changed-py-files.outputs.any_changed == 'true'
run: mypy ${{ steps.changed-py-files.outputs.all_changed_files }}
2 changes: 1 addition & 1 deletion .github/workflows/push_dockerhub_dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
fail-fast: false
steps:
- name: Check out code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Build nfcore/tools:dev docker image
run: docker build --no-cache . -t nfcore/tools:dev
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/push_dockerhub_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
fail-fast: false
steps:
- name: Check out code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Build nfcore/tools:latest docker image
run: docker build --no-cache . -t nfcore/tools:latest
Expand Down
53 changes: 0 additions & 53 deletions .github/workflows/pytest-frozen-ubuntu-20.04.yml

This file was deleted.

Loading
Loading