Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix internal error serde #4570

Merged
merged 3 commits into from
Nov 30, 2023
Merged

fix internal error serde #4570

merged 3 commits into from
Nov 30, 2023

Conversation

modship
Copy link
Member

@modship modship commented Nov 29, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon
Copy link
Collaborator

@modship can you rebase on pre_mainnet_wip branch please? So we can create a 27.2 from this directly

@bilboquet
Copy link
Contributor

I've tested this branch, and it solves the problem described in #4555

Leo-Besancon
Leo-Besancon approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solve, this seems hard to catch! Approved once rebased on pre_mainnet_wip.
Do you think there is potentially other cases where something like this may happen?

@aoudiamoncef
Copy link
Contributor

We have to reuse existing tests like we did here and add Serde usecase to be sure

@modship modship changed the base branch from buildnet to pre_mainnet_wip November 30, 2023 08:05
@modship
Copy link
Member Author

modship commented Nov 30, 2023

@modship can you rebase on pre_mainnet_wip branch please? So we can create a 27.2 from this directly

done

@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6783c2) 71.76% compared to head (5e3e46f) 71.76%.

Additional details and impacted files 
@@               Coverage Diff                @@
##           pre_mainnet_wip    #4570   +/-   ##
================================================
  Coverage            71.76%   71.76%           
================================================
  Files                  291      291           
  Lines                51301    51301           
================================================
  Hits                 36818    36818           
  Misses               14483    14483

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@modship modship merged commit 223cda7 into pre_mainnet_wip Nov 30, 2023
12 checks passed
@modship modship deleted the fix_internal_error branch November 30, 2023 09:47
damip added a commit that referenced this pull request Nov 30, 2023
@Leo-Besancon @sydhds
@bilboquet @modship @AurelienFT @damip
Pre mainnet WIP (#4563)
faebb5a 
* Update version & CI

* Test/array indexing checkup 1 (#4560)

* Update ci.yml

* Feature/feature/versioning ser der harden 2 (#4554)

* Add some unit tests for versioning deserialization to the limits

* Clippy pass

* Better error message

* Minor fixes

* Excluded -> Included

---------

Co-authored-by: sydhds <[email protected]>

* Add versioninig key & value checks (#4552)

* Add versioninig key & value checks

* Improve error message when no prefix

---------

Co-authored-by: sydhds <[email protected]>

* Update CI, Version and genesis timestamp

* Add array indexing listing tool

* Remove array indexing in denunciation code

* Remove more array indexing

* Add more exclude patterns

* Use nom take

---------

Co-authored-by: sydhds <[email protected]>

* Fails in send_operations if get_gas_usage() > max_gas_per_block

Returning a distinct error message for ExecuteSC and CallSC operations.

Signed-off-by: Jean-François <[email protected]>

* coins spending tests (#4532)

* Buildnet WIP

* Mock Final State/Improve tests execution (#4512)

* Use a controller for final state to be able to mock it

* Fix all formatting issues.

* Use more mocks in execution tests

* Fix test nested call usage

* improve some tests execution

* Fix tests async message and compact the test of executed

* Fix more execution tests

* Fix more tests.

* Update more tests

* Finish fixing all executions tests.

* Improve naming

* add more comment

* Fix comment

* update test to check spend coins with readonly

* add coins

* check coins on rollbuy

* clippy

* update roll_buy

* delete helloworld wasm

* update test_readonly_execution

* fix tests merge

* fix test test_readonly_execution

* Update ci.yml

* Feature/feature/versioning ser der harden 2 (#4554)

* Add some unit tests for versioning deserialization to the limits

* Clippy pass

* Better error message

* Minor fixes

* Excluded -> Included

---------

Co-authored-by: sydhds <[email protected]>

* Add versioninig key & value checks (#4552)

* Add versioninig key & value checks

* Improve error message when no prefix

---------

Co-authored-by: sydhds <[email protected]>

* Update CI, Version and genesis timestamp

* add test for cancel_async_msg

* clippy

* cancel async msg check refound sender

---------

Co-authored-by: Leo-Besancon <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: sydhds <[email protected]>

* improve errors (#4567)

* tech(async_msg) : check if the target address exist

* tech(call_sc) : add check target address to call_sc_op

* check target sc address on init_call

* check target address in read only call

* fix unit tests

* remove dbg macro

* Update massa-execution-worker/src/context.rs

Co-authored-by: Damir Vodenicarevic <[email protected]>

---------

Co-authored-by: Damir Vodenicarevic <[email protected]>

* Fix tests (#4568)

* Fix CI WIP (#4569)

* Fix ws_disabled() test on windows

* fix bootstrap server port

* Fix CI local Leo

* Update scenarios_mandatories.rs

* Add CI profile argument to nextest

---------

Co-authored-by: modship <[email protected]>

* Fix test + Update lcov.info

* Add codecov.yml

* fix internal error serde (#4570)

* Release prebuilt profile (#4572)

* codegen-units set to 1 for prebuilt binaries

* Update toolchain version in CI & CD

* Update CI & Genesis

---------

Signed-off-by: Jean-François <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: sydhds <[email protected]>
Co-authored-by: Jean-François <[email protected]>
Co-authored-by: Modship <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Damir Vodenicarevic <[email protected]>
Leo-Besancon added a commit that referenced this pull request Nov 30, 2023
@Leo-Besancon @sydhds
@bilboquet @modship @AurelienFT @damip
Pre mainnet WIP (#4563)
4ae11de 
* Update version & CI

* Test/array indexing checkup 1 (#4560)

* Update ci.yml

* Feature/feature/versioning ser der harden 2 (#4554)

* Add some unit tests for versioning deserialization to the limits

* Clippy pass

* Better error message

* Minor fixes

* Excluded -> Included

---------

Co-authored-by: sydhds <[email protected]>

* Add versioninig key & value checks (#4552)

* Add versioninig key & value checks

* Improve error message when no prefix

---------

Co-authored-by: sydhds <[email protected]>

* Update CI, Version and genesis timestamp

* Add array indexing listing tool

* Remove array indexing in denunciation code

* Remove more array indexing

* Add more exclude patterns

* Use nom take

---------

Co-authored-by: sydhds <[email protected]>

* Fails in send_operations if get_gas_usage() > max_gas_per_block

Returning a distinct error message for ExecuteSC and CallSC operations.

Signed-off-by: Jean-François <[email protected]>

* coins spending tests (#4532)

* Buildnet WIP

* Mock Final State/Improve tests execution (#4512)

* Use a controller for final state to be able to mock it

* Fix all formatting issues.

* Use more mocks in execution tests

* Fix test nested call usage

* improve some tests execution

* Fix tests async message and compact the test of executed

* Fix more execution tests

* Fix more tests.

* Update more tests

* Finish fixing all executions tests.

* Improve naming

* add more comment

* Fix comment

* update test to check spend coins with readonly

* add coins

* check coins on rollbuy

* clippy

* update roll_buy

* delete helloworld wasm

* update test_readonly_execution

* fix tests merge

* fix test test_readonly_execution

* Update ci.yml

* Feature/feature/versioning ser der harden 2 (#4554)

* Add some unit tests for versioning deserialization to the limits

* Clippy pass

* Better error message

* Minor fixes

* Excluded -> Included

---------

Co-authored-by: sydhds <[email protected]>

* Add versioninig key & value checks (#4552)

* Add versioninig key & value checks

* Improve error message when no prefix

---------

Co-authored-by: sydhds <[email protected]>

* Update CI, Version and genesis timestamp

* add test for cancel_async_msg

* clippy

* cancel async msg check refound sender

---------

Co-authored-by: Leo-Besancon <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: sydhds <[email protected]>

* improve errors (#4567)

* tech(async_msg) : check if the target address exist

* tech(call_sc) : add check target address to call_sc_op

* check target sc address on init_call

* check target address in read only call

* fix unit tests

* remove dbg macro

* Update massa-execution-worker/src/context.rs

Co-authored-by: Damir Vodenicarevic <[email protected]>

---------

Co-authored-by: Damir Vodenicarevic <[email protected]>

* Fix tests (#4568)

* Fix CI WIP (#4569)

* Fix ws_disabled() test on windows

* fix bootstrap server port

* Fix CI local Leo

* Update scenarios_mandatories.rs

* Add CI profile argument to nextest

---------

Co-authored-by: modship <[email protected]>

* Fix test + Update lcov.info

* Add codecov.yml

* fix internal error serde (#4570)

* Release prebuilt profile (#4572)

* codegen-units set to 1 for prebuilt binaries

* Update toolchain version in CI & CD

* Update CI & Genesis

---------

Signed-off-by: Jean-François <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: sydhds <[email protected]>
Co-authored-by: Jean-François <[email protected]>
Co-authored-by: Modship <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Damir Vodenicarevic <[email protected]>
@Leo-Besancon Leo-Besancon linked an issue Nov 30, 2023 that may be closed by this pull request
execute_read_only_bytecode Internal error #4555
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@aoudiamoncef aoudiamoncef Awaiting requested review from aoudiamoncef

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

execute_read_only_bytecode Internal error
4 participants
@modship @Leo-Besancon @bilboquet @aoudiamoncef