Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent expiry period for async message and block operations #4722

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Consistent expiry period for async message and block operations #4722

merged 8 commits into from
Aug 1, 2024

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Jul 9, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Leo-Besancon and others added 6 commits July 2, 2024 17:29
@Leo-Besancon
Asc message execution - requery message bytecode after each message e…
04ed29c 
…xecution (#4710)

* Requery bytecode

* cargo fmt
@Leo-Besancon
fix call stack inconsistency (#4709)
52814d4
@Leo-Besancon
Improve async message checks (#4706)
b64e360 
* Improve async message checks

* Change checks for async messages

* Add unit tests
@Leo-Besancon
Fix ledger change to take into account cancelled message balance chan…
86e1d02 
…ge (#4715)

* Take again the speculative changes after async message cancellation

* use .apply() to merge the two LedgerChanges

* Fix: we cannot combine two ledger changes with apply

* avoid cloning the changes

* Remove comment
@Leo-Besancon @modship
Fix async msg same slot (#4718)
880eec7 
* fix open rpc spec (#4716)

* Add eliminated_new_messages in eliminated_msg

---------

Co-authored-by: Modship <[email protected]>
@sydhds
Consistent expiry period for async message and block operations
fe02ab9
@sydhds sydhds requested a review from Leo-Besancon July 9, 2024 13:49
Leo-Besancon
Leo-Besancon reviewed Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change the validity end for the async messages, I think we also need to update the rules for pruning them. Can you look into it?

@sydhds sydhds requested a review from Leo-Besancon July 10, 2024 14:09
Leo-Besancon
Leo-Besancon approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update!

@Leo-Besancon Leo-Besancon merged commit 736a9ed into mainnet_2_3 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydhds @Leo-Besancon