New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix amount remaining to slash 2 #4733

Merged

Leo-Besancon merged 3 commits into mainnet_2_3 from fix_amount_remaining_to_slash_2

Aug 2, 2024

Collaborator

Leo-Besancon commented Jul 31, 2024

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

Leo-Besancon added 2 commits

July 31, 2024 08:34


          Fix amount_remaining_to_slash_2 calculation

8c7b601


          Rename slashed_coins and calculation to improve readability

8f519e4

Leo-Besancon requested review from modship and bilboquet

July 31, 2024 06:49


          Fix total_slashed_coins to return value

dbec0ba

bilboquet approved these changes

View reviewed changes

Leo-Besancon merged commit 261c44f into mainnet_2_3

Leo-Besancon deleted the fix_amount_remaining_to_slash_2 branch

August 2, 2024 14:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet