Features/tu async message reset 1 #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydhds
force-pushed
the
features/tu_async_message_reset_1
branch
from
3047551 to
e6d6ec3
Compare
Leo-Besancon
approved these changes
Jan 6, 2025
Leo-Besancon
reviewed
Jan 7, 2025
| @@ -1143,8 +1143,6 @@ impl Interface for InterfaceImpl { | |||
| /// | |||
| /// # Arguments: | |||
| /// data: the string data that is the payload of the event | |||
| /// | |||
| /// [DeprecatedByNewRuntime] Replaced by `get_current_slot` | |||
There was a problem hiding this comment.
This is a typo, but still valid info IMO, maybe just replace get_current_slot by generate_event_wasmv1 instead of removing the comment
There was a problem hiding this comment.
wasmv1 is unused so why bother here?
There was a problem hiding this comment.
Do what you think is best! I just felt it good to stay consistant (remove it or keep it everywhere), but it's a non issue :)
Leo-Besancon
reviewed
Jan 7, 2025
| .set_expectations(|ledger_controller| { | ||
| ledger_controller | ||
| .expect_get_balance() | ||
| .returning(|_| Some(Amount::from_str("200").unwrap())); |
There was a problem hiding this comment.
I think changing this changed the final state and so changed the generated address
Leo-Besancon
pushed a commit
that referenced
this pull request
Jan 17, 2025
* Add send_message_then_reset_bytecode TU * Code cleanup * Minor updates * Update address for sandbox mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.