Adding support for experimental 'metadata' block. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for putting top level fields into a 'metadata' block for organization purposes. It also ships a 'conf' field to the publish endpoint containing the full contents of the `massdriver.yaml` file. The goal is that the CLI will not need to be kept aware of changes to the spec and will simply ship the config off to the pkg manager. This will make it easier to make changes to the structure of massdriver YAML files since it doesnt have to be changed in the pkg manager and the CLI. TODOs: * [ ] remove TODOs / notes * [ ] Fix validate schema logic (bundle.LintSchema) * [ ] Move JSON Schemas to gh json-schemas repo, pull for CLI & backend * [ ] Add code to 'upgrade' schema definitions * [ ] Remove legacy
coryodaniel
force-pushed
the
feature/cory/metadata-top-level
branch
from
83d75cb to
32e1700
Compare
xpositivityx
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for initial review. This will probably require some tweaking, but wanted to get it up to socialize the idea. There will be accompanying changes in massdriver/massdriver to capture the
conffield and store all bundle details on publish.This adds support for putting top level fields into a 'metadata' block for organization purposes. This enables a few features for massdriver:
It also ships a 'conf' field to the publish endpoint containing the full contents of the
massdriver.yamlfile. Ideally the 'conf' will just be the post body, but that would require significant changes that I think are better to be done once we aren't handling this in a backwards compat manner.The goal is that the CLI will not need to be kept aware of changes to the spec and will simply ship the config off to the pkg manager.
This will make it easier to make changes to the structure of massdriver YAML files since it doesnt have to be changed in the pkg manager and the CLI.
TODOs: