Skip to content

Commit

Permalink
Patternlab/dp 2080 reset breakpoints (#597)
Browse files Browse the repository at this point in the history
* DP-2080: update breakpoints to use rem

* DP-2080: add backstop updates

* DP-2080: add changelog
  • Loading branch information
clair0917 authored and ygannett committed Jun 5, 2019
1 parent 82c528a commit 1b4924f
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 12 deletions.
27 changes: 15 additions & 12 deletions assets/scss/00-base/_breakpoints.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,22 @@ $bp-l-ex: 1050px;
$bp-xl: 1200px;


// use of rem values for better responsive layouts
// and better accessibility at zoom levels

// Global breakpoint media variables.
$bp-x-small-min: "min-width: " + ($bp-xs + 1);
$bp-x-small-max: "max-width:" + $bp-xs;
$bp-small-min: "min-width: " + ($bp-s + 1);
$bp-small-max: "max-width:" + $bp-s;
$bp-medium-min: "min-width: " + ($bp-m + 1);
$bp-medium-max: "max-width:" + $bp-m;
$bp-large-min: "min-width: " + ($bp-l + 1);
$bp-large-max: "max-width:" + $bp-l;
$bp-large-extended: "max-width:" + $bp-l-ex;
$bp-large-extended-min: "min-width: " + ($bp-l-ex + 1);
$bp-x-large-min: "min-width: " + ($bp-xl + 1);
$bp-x-large-max: "max-width:" + $bp-xl;
$bp-x-small-min: "min-width: 30.06rem"; // 481px
$bp-x-small-max: "max-width: 30rem"; // 480px
$bp-small-min: "min-width: 38.81rem"; // 621px
$bp-small-max: "max-width: 38.75rem"; // 620px
$bp-medium-min: "min-width: 48.81rem"; // 781px
$bp-medium-max: "max-width: 48.75rem"; // 780px
$bp-large-min: "min-width: 56.94rem"; // 911px
$bp-large-max: "max-width: 56.88rem"; // 910px
$bp-large-extended: "max-width: 65.69rem"; // 1051px
$bp-large-extended-min: "min-width: $bp-l-ex"; // 1050px
$bp-x-large-min: "min-width: 75.06rem"; // 1201px
$bp-x-large-max: "max-width: 75rem"; // 1200px

$bp-page-width-min: "min-width:" + ($max-width + 1);
$bp-page-width-max: "max-width:" + $max-width;
Expand Down
4 changes: 4 additions & 0 deletions changelogs/DP-2080.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
___EXAMPLE___
Minor
Changed
- (Patternlab) [Breakpoints] DP-2080: Investigate Action Nav Details Div overlapping body content when OS settings are zoomed
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 1b4924f

Please sign in to comment.