Add unlisted visibility on Long click #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ter
suggested changes
Jul 3, 2022
mastodon/src/main/java/org/joinmastodon/android/fragments/ComposeFragment.java
Outdated
Show resolved
Hide resolved
| @@ -1056,6 +1064,12 @@ public boolean onMenuItemClick(MenuItem item){ | |||
| menu.show(); | |||
| } | |||
|
|
|||
| private boolean onVisibilityLongClick(View v) { | |||
There was a problem hiding this comment.
Why isn't this void as the onVisibilityClick()?
There was a problem hiding this comment.
LongClickListener should return boolean value. It is handler
There was a problem hiding this comment.
Yeah, thanks for the explanation. I didn't know that OnClickListener and OnLongClickListener were different in this regard.
https://developer.android.com/reference/android/view/View.OnClickListener
https://developer.android.com/reference/android/view/View.OnLongClickListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of people want to use "unlisted" visibility. But @Gargron said that
So this PR keeps that dropdown menu simple, but few changes.
screen-20220525-172024.mp4