tootcli fix-duplicates bugs

[shleeable]

Steps to reproduce the problem

Running the current fix-duplicates toolcli adds the index_tags_on_name_lower index back, even after the mitgrate has removed it.

mastodon/lib/mastodon/maintenance_cli.rb

Line 512 in b07906b

ActiveRecord::Base.connection.add_index :tags, 'lower((name)::text)', name: 'index_tags_on_name_lower', unique: true

https://github.com/mastodon/mastodon/blob/main/db/migrate/20210421121431_add_case_insensitive_btree_index_to_tags.rb

Expected behaviour

index should be removed

Actual behaviour

index is recreated.

Specifications

main

[shleeable]

Similar issue with index_users_on_remember_token might be n

ERROR:  index "index_users_on_remember_token" does not exist
STATEMENT:  DROP INDEX  "index_users_on_remember_token"

mastodon/lib/mastodon/maintenance_cli.rb

Line 276 in b07906b

ActiveRecord::Base.connection.add_index :users, ['remember_token'], name: 'index_users_on_remember_token', unique: true if ActiveRecord::Migrator.current_version < 20220118183010

Was this deleted here?

https://github.com/mastodon/mastodon/blob/main/db/post_migrate/20220118183123_remove_rememberable_from_users.rb

[shleeable]

for @ClearlyClaire

[ClearlyClaire]

Running the current fix-duplicates toolcli adds the index_tags_on_name_lower index back, even after the mitgrate has removed it.

mastodon/lib/mastodon/maintenance_cli.rb

Line 512 in b07906b

ActiveRecord::Base.connection.add_index :tags, 'lower((name)::text)', name: 'index_tags_on_name_lower', unique: true

https://github.com/mastodon/mastodon/blob/main/db/migrate/20210421121431_add_case_insensitive_btree_index_to_tags.rb

Oops, re-inserting it should have been conditional indeed.

Similar issue with index_users_on_remember_token might be n

ERROR:  index "index_users_on_remember_token" does not exist
STATEMENT:  DROP INDEX  "index_users_on_remember_token"

This is not an error when adding an index, but when attempting to remove it. However, the script should not error out if the index doesn't exist. Can I get more context for this error?

mastodon/lib/mastodon/maintenance_cli.rb

Line 276 in b07906b

ActiveRecord::Base.connection.add_index :users, ['remember_token'], name: 'index_users_on_remember_token', unique: true if ActiveRecord::Migrator.current_version < 20220118183010

Was this deleted here?

https://github.com/mastodon/mastodon/blob/main/db/post_migrate/20220118183123_remove_rememberable_from_users.rb

No, it's deleted in https://github.com/mastodon/mastodon/blob/main/db/post_migrate/20220118183010_remove_index_users_on_remember_token.rb