Streaming: refactor to custom Error classes #28632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that must be resolved before it can be merged. |
This enables better handling of the errors rather than just adding properties to the Error instance
ThisIsMissEm
force-pushed
the
refactor/custom-errors-for-streaming
branch
from
68712da to
b9c4a1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28632 +/- ##
========================================
Coverage 85.07% 85.08%
========================================
Files 1038 1061 +23
Lines 28142 28339 +197
Branches 4532 4545 +13
========================================
+ Hits 23943 24112 +169
- Misses 3039 3065 +26
- Partials 1160 1162 +2 ☔ View full report in Codecov by Sentry. |
ThisIsMissEm
commented
Jan 19, 2024
|
This pull request has resolved merge conflicts and is ready for review. |
ThisIsMissEm
commented
Jan 19, 2024
ThisIsMissEm
commented
Jan 19, 2024
ThisIsMissEm
commented
Jan 19, 2024
|
@renchap @ClearlyClaire I think this should be easily mergeable? |
Co-authored-by: Claire <[email protected]>
renchap
approved these changes
Feb 22, 2024
renchap
approved these changes
Feb 22, 2024
ClearlyClaire
approved these changes
Feb 22, 2024
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Feb 27, 2024
Co-authored-by: Renaud Chaput <[email protected]> Co-authored-by: Claire <[email protected]>
Ember-ruby
pushed a commit
to Ember-ruby/mastodon-glitch
that referenced
this pull request
Mar 19, 2024
Co-authored-by: Renaud Chaput <[email protected]> Co-authored-by: Claire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables better handling of the errors rather than just adding properties to the Error instance. This is currently a draft until #27828 is merged.
We also need to take a deeper look at the
on("error")handlers for websockets and eventstreams to double check that we're not accidentally sending confidential information about errors to the clients.I will also note that we're approaching the time to do a reorganisation of the
streaming/directory into astreaming/src/*andstreaming/index.jsthat just starts the server listening, however, due to other inflight work, I don't wish to do this reorganisation yet, as it'd create merge and rebase conflicts.