Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use heredoc/squish for inline css styles in oembed serializer #31991

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

mjankowski
Copy link
Contributor

Noticed this while looking at #31990

The main change here is to pull these out to a heredoc'd/squish'd arrangement to make for slightly easier "css editing" if/when these need to be changed. Tried to improve the hash keys a bit while in there.

As a fun side project, I discovered some what I think is broken CSS/heredoc/hash syntax highlighting bugs in my editor, which I'll report to the relevant local authorities.

@ClearlyClaire
Copy link
Contributor

As a fun side project, I discovered some what I think is broken CSS/heredoc/hash syntax highlighting bugs in my editor, which I'll report to the relevant local authorities.

Does it actually detect these as CSS? If not, would a heredoc with name CSS instead of STYLES help?

ClearlyClaire
ClearlyClaire previously approved these changes Sep 20, 2024
@mjankowski
Copy link
Contributor Author

It should detect the heredoc contents as CSS when the start marker includes CSS, but seems slightly broken. That said, I'd rather not do a followup PR just to rename a marker ... so pushed a change here to use CSS, and will attempt to sort out the editor stuff separately.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Sep 20, 2024
Merged via the queue into mastodon:main with commit a7dbf6f Sep 20, 2024
29 checks passed
@mjankowski mjankowski deleted the oembed-style-constants branch September 20, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants