Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert auth/passwords spec controller->system/request #33790

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

mjankowski
Copy link
Contributor

Pretty straightforward, notes:

  • There was a typo in the controller spec where one of the invalid update case checks was doing a post to update (instead of put). This was hitting the correct controller action, but the template check (new vs edit) was wrong due to the wrong action. Corrected this in request spec.
  • I was able to combine basically all of the "trigger reset email and update pass" flow into one larger step, including actually sending/extracting the link from email, which both reads better to me, but also reduces total factory creation a bit.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Jan 31, 2025
Merged via the queue into mastodon:main with commit c5cd9bd Jan 31, 2025
31 checks passed
@mjankowski mjankowski deleted the spec-auth-passwords branch January 31, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants