Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GooglePlaces 8.5.0 and google_maps 7.1.0 #78

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

fleoparra
Copy link
Contributor

Google Places works on ios 14 without problem. ios was downgraded from 15 to 14 introduced in commit 85ad330. GooglePlaces was upgraded from 8.3.0 to 8.5.0. Because of a dependency was necessary to upgraded google_maps on web to 7.1.0. This fix #75

Google Places works on ios 14 without problem. ios was downgraded from 15 to 14. GooglePlaces was upgraded from 8.3.0 to 8.5.0. Because of a dependency was necessary to upgraded google_maps on web to 7.1.0
@stsc3000
Copy link

👋 Awesome, @fleoparra.

@matanshukry I think we need this for two reasons:

  • GooglePlaces 8.5.0 supports privacy manifests
  • We use flutter_google_places_sdk along with google_maps_flutter. google_maps_flutter_web 0.5.6+2 depends on google_maps 7.1.0.

@matanshukry matanshukry merged commit 335b54b into matanshukry:master Apr 20, 2024
0 of 2 checks passed
@aggeloskoutanis
Copy link

@stsc3000 What you mentioned is still a problem in version 2.6.1. Does anyone know when this is going to be fixed?

@larry-cariq
Copy link

@fleoparra Thanks for this PR as this will solve my problem with GooglePlaces 8.5.0 and iOS 14.0.

@matanshukry Do you know when the package flutter_google_places_sdk_ios will be updated to include this?

@matanshukry
Copy link
Owner

@aggeloskoutanis @larry-cariq @fleoparra @stsc3000

Published the iOS package under version 0.1.5, and the sdk (user-facing) package with the new 0.1.5 endorsed in version 0.3.8

@stsc3000
Copy link

Thank you, @matanshukry 🎉

@stsc3000
Copy link

@matanshukry Thanks for your work. We still seem to have a conflict regarding the google_maps dependency in flutter_google_places_sdk_web. Does _web still require a release?

@matanshukry
Copy link
Owner

@stsc3000 I missed the change to the web, I didn't even test it.
It should have been in a different commit.

Anyway will check it out now

@matanshukry
Copy link
Owner

@stsc3000 done; updated web to 0.1.7, and sdk to endorse it at 0.3.9

@stsc3000
Copy link

Thanks again, @matanshukry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Google Maps dependency
5 participants