Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added a check for a hardcoded aria 'role' value in the same element. #493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Added a check for a hardcoded aria 'role' value in the same element. #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/assemble/_landmarksFinder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,21 +451,34 @@ export default function LandmarksFinder(win, doc, _testUseHeuristics) {
function tryFindingMain() {
if (mainElementIndices.length === 0) {
for (const id of ['main', 'content', 'main-content']) {
if (addGuessed(doc.getElementById(id), 'main')) return
let element = doc.getElementById(id);
if (element && element.getAttribute('role') !== 'main') {
if (addGuessed(element, 'main')) return;
}
}
const classMains = doc.getElementsByClassName('main');
for (const guessed of classMains) {
if (guessed.getAttribute('role') !== 'main') {
addGuessed(guessed, 'main');
}
}
const classMains = doc.getElementsByClassName('main')
if (classMains.length === 1) addGuessed(classMains[0], 'main')
}
}


function tryFindingNavs() {
if (!foundNavigationRegion) {
for (const id of ['navigation', 'nav']) {
if (addGuessed(doc.getElementById(id), 'navigation')) break
let element = doc.getElementById(id);
if(element && element.getAttribute('role') !== 'navigation') {
if (addGuessed(element, 'navigation')) break;
}
}
for (const className of ['navigation', 'nav']) {
for (const guessed of doc.getElementsByClassName(className)) {
addGuessed(guessed, 'navigation')
if(guessed.getAttribute('role') !== 'navigation') {
addGuessed(guessed, 'navigation');
}
}
}
}
Expand Down
Loading