-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add solution by Faiza Hamid #11
base: main
Are you sure you want to change the base?
Conversation
@@ -12,6 +12,7 @@ | |||
|
|||
# Ignore env config | |||
.env | |||
.env.sample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this file be here?
@@ -20,3 +21,4 @@ node_modules | |||
deploy_logs.json | |||
|
|||
temp | |||
Makefile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you add it to gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api/src/models/RecruiterProfile.ts
Outdated
type: DataType.STRING(255), | ||
field: 'city', | ||
}) | ||
city: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the field is nullable but has strict type string
, let's set it can be string or null
@@ -17,6 +17,8 @@ export const RecruiterProfileMeta = React.memo<Props>((props) => { | |||
className={cn(styles.recruiterMetaItem, typography.smallHeading)} | |||
key={item.name} | |||
> | |||
{item.icon && <item.icon />} | |||
{item.name === 'city'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this line mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just forgot to delete.
. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Hello, @vkryvytskyy !
Execution of the command npx sequelize db:migrate:
Migration
Execution of the command npx sequelize db:seed:all:
Seed
Result:
Result