Test task | Maksym Perekhodko | [email protected] #8
Conversation
|
|
||
| for (const profile of profiles) { | ||
| const city = cities[Math.floor(Math.random() * cities.length)]; | ||
| await queryInterface.bulkUpdate( |
There was a problem hiding this comment.
was it required to update all profiles in the database?
|
|
||
| @AllowNull(true) | ||
| @Column | ||
| city: string; |
| @@ -19,11 +19,13 @@ export const RecruiterProfileSchema = gql` | |||
| userId: Int! | |||
| position: String! | |||
| companyName: String! | |||
| city: String! | |||
There was a problem hiding this comment.
field is nullable in db but required in graphql schema, why?
There was a problem hiding this comment.
thanks for the catch! will fix in the next commit
| GetAdminUserOptions, | ||
| GetAdminUserResult, | ||
| } from '@/modules/user/user.useCases/GetAdminUser.useCase'; | ||
| GetAdminUserUseCaseOptions, |
There was a problem hiding this comment.
why are these changes here?
There was a problem hiding this comment.
TS compilation have been failing due to missing GetAdminUserOptions and other imports
| @@ -17,6 +19,7 @@ export const RecruiterProfileMeta = React.memo<Props>((props) => { | |||
| className={cn(styles.recruiterMetaItem, typography.smallHeading)} | |||
| key={item.name} | |||
| > | |||
| {item.name === RecruiterProfileMetaItems.City && <IconLocation />} | |||
There was a problem hiding this comment.
what if we need an icon for another item? can we somehow modify the incoming array?
There was a problem hiding this comment.
thanks! will fix in the next commit
| for (const profile of profiles) { | ||
| const city = cities[Math.floor(Math.random() * cities.length)]; | ||
| await queryInterface.bulkUpdate( | ||
| 'recruiter_profiles', | ||
| { city }, | ||
| { id: profile.id }, | ||
| { transaction: t } | ||
| ); | ||
| } |
There was a problem hiding this comment.
can we make a single request to the DB instead of profiles.length requests?
There was a problem hiding this comment.
What is better: single or multiple?
There was a problem hiding this comment.
we can generate a single query or just make a single bulkUpdate request and this way make a single request to a database.
thanks for the notice! will fix in the next commit
Unfortunately, I am currently unable to provide a video of the seeder work due to some hardware issues. I apologize for the inconvenience and will provide the video as soon as the problem is resolved. |
|
. |
@vkryvytskyy
Hi, I’m Maksym Perekhodko!
Here is my task solution:
According to the task, I've added a new nullable
citycolumn of typecharacter varying(255)to therecruiter_profilestable using Sequelize migrations. Updated theRecruiterProfilemodel and GraphQL schema to include the newcityfield. Seeded the database with random Ukrainian city names for existing profiles. Modified the UI to display thecitydata in the recruiter profile view.Videos: