'commit' #580
Open
'commit' #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViPiven
commented
Mar 25, 2021
ViPiven
commented
- DEMO LINK
- TEST REPORT LINK
varseniuk
suggested changes
Mar 29, 2021
src/index.html
Outdated
Comment on lines
5
to
6
| <meta name="viewport" | ||
| content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"> |
There was a problem hiding this comment.
Suggested change
| <meta name="viewport" | |
| content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"> | |
| <meta | |
| name="viewport" | |
| content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0" | |
| > |
src/index.html
Outdated
Comment on lines
18
to
20
| <img src="images/logo.png" | ||
| alt="Moyo-logo" | ||
| > |
There was a problem hiding this comment.
Suggested change
| <img src="images/logo.png" | |
| alt="Moyo-logo" | |
| > | |
| <img src="images/logo.png" alt="Moyo-logo"> |
src/index.html
Outdated
Comment on lines
34
to
37
| <a href="#" | ||
| class="nav__item" | ||
| data-qa="hover" | ||
| > |
There was a problem hiding this comment.
Suggested change
| <a href="#" | |
| class="nav__item" | |
| data-qa="hover" | |
| > | |
| <a | |
| href="#" | |
| class="nav__item" | |
| data-qa="hover" | |
| > |
src/style.css
Outdated
Comment on lines
57
to
60
| .nav__link:last-child, | ||
| .nav__link:last-child .nav__item { | ||
| margin-right: 0; | ||
| } |
There was a problem hiding this comment.
Suggested change
| .nav__link:last-child, | |
| .nav__link:last-child .nav__item { | |
| margin-right: 0; | |
| } | |
| .nav__link:last-child { | |
| margin-right: 0; | |
| } |
src/style.css
Outdated
Comment on lines
74
to
76
| .nav__item.is-active { | ||
| color: #00acdc; | ||
| } |
There was a problem hiding this comment.
Suggested change
| .nav__item.is-active { | |
| color: #00acdc; | |
| } | |
| .nav__item.is-active, | |
| .nav__item:hover { | |
| color: #00acdc; | |
| } |
Don't repeat yourself
src/style.css
Outdated
| } | ||
|
|
||
| .nav__item.is-active:after { | ||
| opacity: 1; |
ViPiven
commented
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.