Develop Moyo Header #6179
Develop Moyo Header #6179
Conversation
ArtBlack20
commented
Feb 27, 2025
ArtBlack20
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Great job on meeting most of the task requirements! 🎉 While there are a few minor issues, such as the use of href="#" and ensuring meaningful alt attributes for images, these don't critically impact the functionality. Keep up the good work and consider these suggestions for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <h1>Moyo header</h1> | ||
| <header class="header"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause the page to jump to the top when clicked. Consider using actual URLs or handling the click event with JavaScript to prevent default behavior.
| <ul class="nav__list"> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause the page to jump to the top when clicked. Consider using actual URLs or handling the click event with JavaScript to prevent default behavior.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause the page to jump to the top when clicked. Consider using actual URLs or handling the click event with JavaScript to prevent default behavior.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause the page to jump to the top when clicked. Consider using actual URLs or handling the click event with JavaScript to prevent default behavior.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause the page to jump to the top when clicked. Consider using actual URLs or handling the click event with JavaScript to prevent default behavior.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause the page to jump to the top when clicked. Consider using actual URLs or handling the click event with JavaScript to prevent default behavior.
|
|
||
| <li class="nav__item"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause the page to jump to the top when clicked. Consider using actual URLs or handling the click event with JavaScript to prevent default behavior.
| </li> | ||
| <li class="nav__item"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Using href="#" is not recommended as it can cause the page to jump to the top when clicked. Consider using actual URLs or handling the click event with JavaScript to prevent default behavior.
| class="logo" | ||
| > | ||
| <img | ||
| src="./images/logo.png" |
There was a problem hiding this comment.
Ensure the alt attribute provides a meaningful description of the image for better accessibility. Currently, it just states 'MOYO Logo', which might be sufficient if the logo is purely decorative, but consider adding more context if needed.
| padding: 0; | ||
| } | ||
|
|
||
| :not(:first-of-type) { |
There was a problem hiding this comment.
The :not(:first-of-type) selector is used here, but it's not clear what elements it is targeting. Make sure it is applied to the correct elements to achieve the desired spacing effect. Consider adding a more specific selector or context to ensure it works as intended.
