Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #6198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #6198

wants to merge 1 commit into from

Conversation

melarkkkk
Copy link

DEMO LINK
TEST REPORT LINK

  • [x ] Header height is set in 1 place (for the links)
  • [x ] Content is vertically centered (for any header height)
  • [ x] CSS is used to show all letters in Uppercase (don't type them in HTML)
  • [ x] Logo is an image wrapped with a link
  • [ x] CSS Variable is used for a blue color
  • [ x] Pseudo-element is used for a blue line below the active link
  • [ x] Code follows all the Code Style Rules ❗️
  • [ x] The Google Fonts Configuration follows requirements.
    alt text

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 Your code is well-structured and meets most of the task requirements. The use of semantic tags and CSS variables is spot on. There are a couple of minor issues to address in future projects: consider avoiding the * selector for better performance and ensure the font specification strictly follows the task description. Keep up the good work, and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants