Fixing Window List - stretched buttons on vertical orientation #269

[mihai-bica]

Hi,
This is fixing the bug #269. I am wondering if it is OK to remove the ifdef WNCK_CHECK_VERSION. I did a grep for WNCK_CHECK_VERSION and didn't find it defined on my system.

The fix was tested on linux mint 17 and on debian 8.

Thanks,
Mihai

[monsta]

Not sure how it was tested, but wnck_tasklist_set_orientation is available only in libwnck >= 3.4.6 while GTK+2 build of mate-panel uses libwnck 2.30.

[mihai-bica]

I tested this on branch 1.8 because it compiles easily on Mint 17. I cannot build and test the code on branch master because I have some dependency problems on my machine.

The function wnck_tasklist_set_orientation is available from libwnck 1:
mihai@mihai-vb ~ $ strings /usr/lib/libwnck-1.so.22.3.31 | grep wnck_tasklist_set_orientation
wnck_tasklist_set_orientation
mihai@mihai-vb ~ $
It is also available in the headers of package sudo apt-get install libwnck-dev:
mihai@mihai-vb ~ $ grep wnck_tasklist_set_orientation /usr/include/libwnck-1.0/libwnck/tasklist.h
void wnck_tasklist_set_orientation(WnckTasklist *tasklist, GtkOrientation orient);
mihai@mihai-vb ~ $

However, the function wnck_tasklist_set_middle_click_close is available only from libwnck 3, so I reverted the change and kept the ifdef around wnck_tasklist_set_middle_click_close.

[monsta]

I've checked it out - it's a Debian-specific patch. It's also inherited in Ubuntu so it's the same in Mint 17.

We can't accept it upstream (unless every distro out there accepts the same patch).

[mihai-bica]

Hi, I agree here:

1. Theoretically, the bug is already fixed for libwnck >= 3.4.6 . The problem appears if the OS has libwnck < 3.4.6
2. Should we close the bug? (I highly suspect that it will not reproduce on libwnck >= 3.4.6. Didn't test on libwnck >= 3.4.6)
3. This is not the place to commit this fix.

If I still want to have this fixed in Debian/Ubuntu/Mint I can either wait until they use libwnck >= 3.4.6 or commit this as a patch to Debian...

Thanks for your investigation.

[monsta]

Don't look at wnck version 3.x.x, it's for GTK+3 build of MATE which is still experimental.
GTK+2 build of MATE (the default) uses wnck 2.30.x. It cannot use wnck 3.x.x - that is by design.