Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Commit

Permalink
fix(rtl): Adding noflip annotations to fix downstream rtl issues (#2344)
Browse files Browse the repository at this point in the history
* fix(rtl): Adding noflip annotations to fix downstream rtl issues

* fix(rtl): remove changes to button, will be in separate PR

* fix(rtl): remove changes to button, will be in separate PR - second attempt.

* fix(rtl): removed extra whitespace
  • Loading branch information
aprigogin authored Mar 5, 2018
1 parent eb4138e commit dc3d69f
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
10 changes: 10 additions & 0 deletions packages/mdc-ripple/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,17 @@

&.mdc-ripple-upgraded::after {
top: 0;

/* @noflip */
left: 0;
transform: scale(0);
transform-origin: center center;
}

&.mdc-ripple-upgraded--unbounded::after {
top: var(--mdc-ripple-top, 0);

/* @noflip */
left: var(--mdc-ripple-left, 0);
}

Expand Down Expand Up @@ -175,6 +179,8 @@
&::before,
&::after {
top: calc(50% - #{$radius});

/* @noflip */
left: calc(50% - #{$radius});
width: $radius * 2;
height: $radius * 2;
Expand All @@ -190,6 +196,8 @@
&::before,
&::after {
top: calc(50% - #{$radius / 2});

/* @noflip */
left: calc(50% - #{$radius / 2});
width: $radius;
height: $radius;
Expand All @@ -198,6 +206,8 @@
&.mdc-ripple-upgraded::before,
&.mdc-ripple-upgraded::after {
top: var(--mdc-ripple-top, calc(50% - #{$radius / 2}));

/* @noflip */
left: var(--mdc-ripple-left, calc(50% - #{$radius / 2}));
width: var(--mdc-ripple-fg-size, $radius);
height: var(--mdc-ripple-fg-size, $radius);
Expand Down
6 changes: 6 additions & 0 deletions packages/mdc-rtl/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -227,11 +227,17 @@
$right-value,
$root-selector: null
) {
/* @noflip */
#{$left-property}: $left-value;

/* @noflip */
#{$right-property}: $right-value;

@include mdc-rtl($root-selector) {
/* @noflip */
#{$left-property}: $right-value;

/* @noflip */
#{$right-property}: $left-value;
}
}

0 comments on commit dc3d69f

Please sign in to comment.