Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Commit

Permalink
fix: update TypeScript version to 3.5.x and fix typing errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Matt Goo committed Jun 21, 2019
1 parent e8afc42 commit fc7942f
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 14 deletions.
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
"ts-loader": "^3.5.0",
"ts-node": "^8.0.3",
"tslint": "^5.12.0",
"typescript": "^3.1.6",
"typescript": "^3.5.0",
"url-search-params-polyfill": "^6.0.0",
"useragent": "^2.3.0",
"verror": "^1.10.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/mdc-checkbox/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export class MDCCheckbox extends MDCComponent<MDCCheckboxFoundation> implements
}

// Public visibility for this property is required by MDCRippleCapableSurface.
root_!: Element; // assigned in MDCComponent constructor
root_!: HTMLElement; // assigned in MDCComponent constructor

private readonly ripple_: MDCRipple = this.createRipple_();
private handleChange_!: EventListener; // assigned in initialSyncWithDOM()
Expand Down
6 changes: 3 additions & 3 deletions packages/mdc-form-field/adapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
* THE SOFTWARE.
*/

import {EventType, SpecificEventListener} from '@material/base/types';
import {SpecificEventListener} from '@material/base/types';

/**
* Defines the shape of the adapter expected by the foundation.
Expand All @@ -33,6 +33,6 @@ import {EventType, SpecificEventListener} from '@material/base/types';
export interface MDCFormFieldAdapter {
activateInputRipple(): void;
deactivateInputRipple(): void;
deregisterInteractionHandler<K extends EventType>(evtType: K, handler: SpecificEventListener<K>): void;
registerInteractionHandler<K extends EventType>(evtType: K, handler: SpecificEventListener<K>): void;
deregisterInteractionHandler(evtType: 'click', handler: SpecificEventListener<'click'>): void;
registerInteractionHandler(evtType: 'click', handler: SpecificEventListener<'click'>): void;
}
2 changes: 1 addition & 1 deletion packages/mdc-form-field/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class MDCFormField extends MDCComponent<MDCFormFieldFoundation> {
return this.input_;
}

private get label_(): Element | null {
private get label_(): HTMLElement | null {
const {LABEL_SELECTOR} = MDCFormFieldFoundation.strings;
return this.root_.querySelector(LABEL_SELECTOR);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/mdc-radio/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export class MDCRadio extends MDCComponent<MDCRadioFoundation> implements MDCRip
}

// Public visibility for this property is required by MDCRippleCapableSurface.
root_!: Element; // assigned in MDCComponent constructor
root_!: HTMLElement; // assigned in MDCComponent constructor

private readonly ripple_: MDCRipple = this.createRipple_();

Expand Down
2 changes: 1 addition & 1 deletion packages/mdc-ripple/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class MDCRipple extends MDCComponent<MDCRippleFoundation> implements MDCR
}

// Public visibility for this property is required by MDCRippleCapableSurface.
root_!: Element; // assigned in MDCComponent constructor
root_!: HTMLElement; // assigned in MDCComponent constructor

disabled = false;

Expand Down
2 changes: 1 addition & 1 deletion packages/mdc-ripple/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export interface MDCRippleAttachOpts {
* disabled Whether or not the ripple is attached to a disabled component.
*/
export interface MDCRippleCapableSurface {
readonly root_: Element;
readonly root_: HTMLElement;
unbounded?: boolean;
disabled?: boolean;
}
2 changes: 1 addition & 1 deletion packages/mdc-switch/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class MDCSwitch extends MDCComponent<MDCSwitchFoundation> implements MDCR
}

// Public visibility for this property is required by MDCRippleCapableSurface.
root_!: Element; // assigned in MDCComponent constructor
root_!: HTMLElement; // assigned in MDCComponent constructor

private readonly ripple_ = this.createRipple_();

Expand Down
2 changes: 1 addition & 1 deletion packages/mdc-top-app-bar/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class MDCTopAppBar extends MDCComponent<MDCTopAppBarBaseFoundation> {
return new MDCTopAppBar(root);
}

private navIcon_!: Element | null;
private navIcon_!: HTMLElement | null;
private iconRipples_!: MDCRipple[];
private scrollTarget_!: EventTarget;

Expand Down

0 comments on commit fc7942f

Please sign in to comment.