Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Incorrect expansion start point for unbounded ripples #138

Closed
traviskaufman opened this issue Dec 20, 2016 · 0 comments
Closed

Incorrect expansion start point for unbounded ripples #138

traviskaufman opened this issue Dec 20, 2016 · 0 comments
Assignees
@traviskaufman
Labels
backlog bug

Comments

@traviskaufman
Copy link
Contributor

What MDC Version are you using? (please be specific, e.g. major.minor.patch)

0.1.1

What browser(s) is this bug affecting (including version)?

All

What OS (and version) are you using?

Mac OS X 10.11.6

What are the steps to reproduce the bug? Can you create a plunker/codepen/jsfiddle which reproduces it?

  1. checkout master, npm i, npm run dev
  2. navigation to http://localhost:8080/ripple.html
  3. Click and hold in the center of the unbounded ripple
  4. Observe where the foreground ripple expands from

What is the expected behavior?

The foreground ripple should expand from the center position where the pointer activated it

What is the actual behavior?

The foreground ripple expands from the top-left portion of the touch point

Any other information you believe would be useful?

This is probably due to the fact that we are either calculating transform origin vars wrong for unbounded ripples in JS, or using them wrong in CSS.

Copied from google/material-design-lite#4844
@traviskaufman traviskaufman added this to the Beta milestone Dec 20, 2016
@traviskaufman traviskaufman mentioned this issue Dec 20, 2016
Closed
@traviskaufman traviskaufman self-assigned this Jan 9, 2017
traviskaufman added a commit that referenced this issue Jan 9, 2017
@traviskaufman
fix(ripple): Use correct start point for unbounded ripple expansion
50d5e75 
Fixes a bug where the start point for the foreground unbounded ripple
would emanate from a different point than where the surface was
interacted with. This was occurring because the positioning offsets were
not being taken into account when computing this point.

Fixes #138
[Delivers #132116569]
@traviskaufman traviskaufman mentioned this issue Jan 9, 2017
Merged
traviskaufman added a commit that referenced this issue Jan 11, 2017
@traviskaufman
fix(ripple): Use correct start point for unbounded ripple expansion (#…
9c9ad82 
…165)

Fixes a bug where the start point for the foreground unbounded ripple
would emanate from a different point than where the surface was
interacted with. This was occurring because the positioning offsets were
not being taken into account when computing this point.

Fixes #138
[Delivers #132116569]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@traviskaufman traviskaufman

Labels
backlog bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@traviskaufman