Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Missing Textfield label primary color application on focus #1435

Closed
marioavs opened this issue Oct 17, 2017 · 2 comments · Fixed by #1820
Closed

Missing Textfield label primary color application on focus #1435

marioavs opened this issue Oct 17, 2017 · 2 comments · Fixed by #1820

Comments

@marioavs
Copy link

marioavs commented Oct 17, 2017

What MDC-Web Version are you using?

0.23.0

What are the steps to reproduce the bug?

  1. Run the demo server (it is also present in the demo site https://material-components-web.appspot.com/textfield.html)
  2. Go to localhost:8080/textfield.html
  3. Check the Dark Theme option for the "Full Functionality JS Component" (second Textfield component). This step is only needed to make more evident the label coloring.
  4. Tab-focus on the "Full Functionality JS Component" (second Textfield component)
  5. Observe the label color

What is the expected behavior?

The label should be displayed with primary color for focused textfield components

What is the actual behavior?

The label is displayed with the normal / idle color as if it would be a non focused textfield component

Any other information you believe would be useful?

It looks like the following is needed and has been removed from packages/mdc-textfield/mdc-textfield.scss, for the mdc-textfield--focused class:
@include mdc-theme-prop(color, primary);

@reddysridhar53
Copy link

Can i take it up?

@dscalzi
Copy link

dscalzi commented Nov 17, 2017

Still an issue on 0.25.0.

dscalzi added a commit to Commit451/skyhook that referenced this issue Jan 18, 2018
… for full-width textfields". Simply removed the class and added a custom style (width: 100%).

Issues with label color is still present, should be fixed with version 0.29.0
See:  material-components/material-components-web#1435
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants