Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(text-field): Update label position and shake animation #2594

Merged
merged 4 commits into from
Apr 19, 2018

Conversation

bonniezhou
Copy link
Contributor

@bonniezhou bonniezhou commented Apr 19, 2018

Fix #2056 (label shake animation for RTL outlined variant with leading icon).
Fix #2575 (label font size and position for dense variants (font-size was being overridden by floating-label selectors).

@bonniezhou bonniezhou requested a review from moog16 April 19, 2018 00:17
@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #2594 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2594   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          98       98           
  Lines        4198     4198           
  Branches      533      533           
=======================================
  Hits         4143     4143           
  Misses         55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c52589...7595cb2. Read the comment docs.

Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bonniezhou bonniezhou merged commit bd84694 into master Apr 19, 2018
@bonniezhou bonniezhou deleted the fix/text-field/label-shake branch April 19, 2018 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants