This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(text-field): Update outline idle border color to match design guidance #4768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiomkar
reviewed
May 28, 2019
| @@ -49,9 +48,11 @@ $mdc-select-disabled-ink-color: rgba(mdc-theme-prop-value(on-surface), .37) !def | |||
| $mdc-select-disabled-fill-color: mix(mdc-theme-prop-value(on-surface), mdc-theme-prop-value(surface), 2%) !default; | |||
| $mdc-select-disabled-dropdown-opacity: .37 !default; | |||
|
|
|||
| $mdc-select-outlined-idle-border: rgba(mdc-theme-prop-value(on-surface), .38) !default; | |||
There was a problem hiding this comment.
Are these design approved? Sometimes the spec is not up to date.
There was a problem hiding this comment.
Yes, just talked with design about them.
abhiomkar
approved these changes
May 28, 2019
|
I'll be accepting the following screenshot diffs with this PR due to CBT upgrading their FF version from 65 to 66. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the select and text field outline idle border color to match spec.
fixes #4767