Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(text-field): Update outline idle border color to match design guidance #4768

Merged
merged 6 commits into from
May 30, 2019
Merged

fix(text-field): Update outline idle border color to match design guidance #4768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df8a28b
fix(text-field): Update outline idle border color to match design gui…
williamernest May 28, 2019
cd74907
WIP: Temp revert textfield for screenshot test timeouts
williamernest May 29, 2019
0c772b7
WIP: Confirm screenshot changes to select
williamernest May 29, 2019
dd85423
WIP: Update goldens
williamernest May 29, 2019
1118dc6
WIP: Accept screenshot diffs from CBT upgrade of FF 65 -> 66
williamernest May 29, 2019
4d02104
Merge branch 'master' into fix/textfield/update-border-color
williamernest May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/mdc-select/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ $mdc-select-helper-text-color: rgba(mdc-theme-prop-value(on-surface), .6) !defau

$mdc-select-fill-color: mix(mdc-theme-prop-value(on-surface), mdc-theme-prop-value(surface), 4%) !default;

$mdc-select-outlined-idle-border: rgba(mdc-theme-prop-value(on-surface), .24) !default;
$mdc-select-dropdown-opacity: .54 !default;

// Disabled Styles
Expand All @@ -49,9 +48,11 @@ $mdc-select-disabled-ink-color: rgba(mdc-theme-prop-value(on-surface), .37) !def
$mdc-select-disabled-fill-color: mix(mdc-theme-prop-value(on-surface), mdc-theme-prop-value(surface), 2%) !default;
$mdc-select-disabled-dropdown-opacity: .37 !default;

$mdc-select-outlined-idle-border: rgba(mdc-theme-prop-value(on-surface), .38) !default;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these design approved? Sometimes the spec is not up to date.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just talked with design about them.

$mdc-select-outlined-hover-border: rgba(mdc-theme-prop-value(on-surface), .87) !default;

// should be .06 after mdc-select opacity is applied
$mdc-select-outlined-disabled-border: rgba(mdc-theme-prop-value(on-surface), .16) !default;
$mdc-select-outlined-hover-border: rgba(mdc-theme-prop-value(on-surface), .87) !default;

$mdc-select-label-position-y: 70% !default;
$mdc-select-outline-label-offset: 16px !default;
Expand Down
2 changes: 1 addition & 1 deletion packages/mdc-textfield/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ $mdc-text-field-background: mix(mdc-theme-prop-value(on-surface), mdc-theme-prop
$mdc-text-field-disabled-background: mix(mdc-theme-prop-value(on-surface), mdc-theme-prop-value(surface), 2%) !default;
$mdc-text-field-secondary-text: rgba(mdc-theme-prop-value(on-surface), .6) !default;

$mdc-text-field-outlined-idle-border: rgba(mdc-theme-prop-value(on-surface), .24) !default;
$mdc-text-field-outlined-idle-border: rgba(mdc-theme-prop-value(on-surface), .38) !default;
$mdc-text-field-outlined-disabled-border: rgba(mdc-theme-prop-value(on-surface), .06) !default;
$mdc-text-field-outlined-hover-border: rgba(mdc-theme-prop-value(on-surface), .87) !default;

Expand Down
Loading