This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix: update TypeScript version to 3.5.x and fix typing errors #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4853 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 119 119
Lines 5650 5650
Branches 749 749
=======================================
Hits 5586 5586
Misses 63 63
Partials 1 1
Continue to review full report at Codecov.
|
|
All 693 screenshot tests passed for commit fc7942f vs. |
added 3 commits
June 21, 2019 13:35
…onents/material-components-web into chore/update-typescript350
This reverts commit fc7942f.
|
All 693 screenshot tests passed for commit 1f03be1 vs. |
|
All 693 screenshot tests passed for commit 7cb4b5f vs. |
abhiomkar
suggested changes
Jun 28, 2019
|
Ah sorry it was lost in this commit 7cb4b5f. I'm un-reverting |
|
updated! |
|
All 699 screenshot tests passed for commit d214746 vs. |
abhiomkar
approved these changes
Jul 1, 2019
|
All 699 screenshot tests passed for commit ef69386 vs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4852
Upgrading TS from 3.2.2 to 3.5.2
Root cause from upgrade is still a bit unknown to me. No changes in 3.3, 3.4, or 3.5 should have caused this type error to occur.
These type errors should have appeared before. The error occurred on add/removeEventListener calls where the root node was type
Element. TypeElementadd/removeEventListener calls expected the handler to be of typeEventListenerOrEventListenerObject, while theSpecificEventListener<K>is specifically for node of typeHTMLElement, and included event handlers likeMouseEvent,KeyboardEvent, etc. These pose problematic as they are a superset of Event.Fix:
I changed theI decided to cast the add/removeEventListener node to antopAppBar,formField, andrippleroot_ elements to beHTMLElementfromElement. This is more correct asHTMLElementis a superset ofElement. Our components should always be using either a SVG element or HTML element of which typeHTMLElementcovers.HTMLElement.