This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(text-field): Handle leading/trailing icons in outlined text field #1858
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d6cb998
Specify box style for leading/trailing icons in demo
bonniezhou 4caa077
Add outlined style to leading/trailing icon demo
bonniezhou 90ea139
WIP including changing label position and changing SVG path to accomm…
bonniezhou 32b9def
WIP wiring up to dense/dark theme
bonniezhou bd5ed1d
Revert all JS changes
bonniezhou d8bb1ba
Get label shake working
bonniezhou 19c1e0c
Parameterize outline path for readability
bonniezhou 0519954
Make keyframes positionX parameter optional
bonniezhou 5b4bac7
Remove extra code
bonniezhou 8224fed
Remove dense/dark mode and extra param
bonniezhou 619c7b9
Revert outline updateSvgPath changes
bonniezhou e1cca1b
Revert demo hero id name change
bonniezhou 62a2e21
Merge branch 'master' into feat/text-field/outline-icon
bonniezhou 8dd79c2
Fix z-indices and label position in dense
bonniezhou 51c60df
Remove useless code and fix label shake
bonniezhou 2afae38
Make linter happy
bonniezhou 01354e1
Remove duplicate code and adjust icon position in dense mode
bonniezhou 19ca8a2
Adjust translateY for label shake
bonniezhou 9454ba4
Fix order for tabindex and remove extra whitespace
bonniezhou d325b8a
Merge branch 'master' into feat/text-field/outline-icon
bonniezhou 05d06c9
Revert changes to do with label shake
bonniezhou a04a2ab
Missed one more change to revert
bonniezhou 1eefbab
Fix tab order for trailing icon
bonniezhou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about removing this advice? I think the intent was to tell people how to make text fields consistent size both with and without icons in them, though that's not really visible from this demo example alone since we only use the class on the icon examples. It might make more sense to move this to a note within the icon readme?
cc @amsheehan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, Alex confirmed it's fine since the input elements have
width:100%
.Making text fields consistent size both with and without icons is done the same way (by setting the width of the top-level
mdc-text-field
element).