This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(ripple): Relax deduplication conditions for touch devices #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1990 +/- ##
==========================================
- Coverage 99.43% 99.43% -0.01%
==========================================
Files 84 84
Lines 3718 3717 -1
Branches 486 485 -1
==========================================
- Hits 3697 3696 -1
Misses 21 21
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problems where a ripple surface would show the ripple twice on touch events, observable on ripple.html on Chrome on Android or Chrome on desktop with device emulation enabled.
The issue is fixed by relaxing the delay to 300ms to match tap delay on touch devices, and by removing the event x/y coordinate comparisons, as apparently sometimes the coordinates can change from the original user-initiated touch event to the simulated mouse event fired by the user agent.