Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(checkbox): Delay checked-unchecked fade #2108

Closed
wants to merge 1 commit into from

Conversation

patrickrodee
Copy link
Contributor

Delay the fade of the checkbox background by 90ms during the transition from checked to unchecked. This makes the checked to unchecked animation a better inversion of the unchecked to checked animation.

Delay the fade of the checkbox background by 90ms during the transition from checked to unchecked. This makes the checked to unchecked animation a better inversion of the unchecked to checked animation.
@patrickrodee
Copy link
Contributor Author

patrickrodee commented Jan 25, 2018

Before

Notice how when going from checked to unchecked the background fade starts at the same time as the check transition.
checkbox-fade--before

After

Notice how when going from checked to unchecked the background fade starts most of the way through the check transition.
checkbox-fade--after

@codecov-io
Copy link

Codecov Report

Merging #2108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2108   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          84       84           
  Lines        3720     3720           
  Branches      485      485           
=======================================
  Hits         3699     3699           
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339e15b...782c122. Read the comment docs.

@allan-chen allan-chen deleted the fix/checkbox/css-background-fade branch January 21, 2020 21:46
copybara-service bot pushed a commit that referenced this pull request Jul 23, 2021
Upcoming work:

* implement theme
* add component tests

fixes #1885
fixes #2109
fixes #2108
fixes #523
fixes #1028
fixes #1671

PiperOrigin-RevId: 367260030
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants