Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(text-field): Add role="button" to icon #2584

Merged
merged 3 commits into from
Apr 19, 2018

Conversation

kfranqueiro
Copy link
Contributor

BREAKING CHANGE: Adds removeAttr(attr) adapter API

BREAKING CHANGE: Adds removeAttr(attr) adapter API
@codecov-io
Copy link

codecov-io commented Apr 18, 2018

Codecov Report

Merging #2584 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2584      +/-   ##
==========================================
+ Coverage   98.68%   98.68%   +<.01%     
==========================================
  Files          98       98              
  Lines        4194     4198       +4     
  Branches      533      533              
==========================================
+ Hits         4139     4143       +4     
  Misses         55       55
Impacted Files Coverage Δ
packages/mdc-textfield/icon/constants.js 100% <ø> (ø) ⬆️
packages/mdc-textfield/icon/foundation.js 100% <100%> (ø) ⬆️
packages/mdc-textfield/icon/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9639689...2892e53. Read the comment docs.

Copy link
Contributor

@bwobrien bwobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfranqueiro kfranqueiro merged commit 4c52589 into master Apr 19, 2018
@kfranqueiro kfranqueiro deleted the fix/text-field/role-button branch April 19, 2018 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants